Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Enable tracing tests when assertions are more lenient #652

Closed
nachocano opened this issue Mar 13, 2020 · 1 comment · Fixed by #734
Closed

Enable tracing tests when assertions are more lenient #652

nachocano opened this issue Mar 13, 2020 · 1 comment · Fixed by #734
Assignees
@ian-mi
Labels
area/test-and-release Test infrastructure, tests or release priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Milestone
v0.14.0-M2

Comments

@nachocano
Copy link
Member

We should enable

knative-gcp/test/e2e/e2e_test.go

Line 145 in 94506c2

t.Skip("Skipping until https://github.com/knative/eventing/issues/2046 is fixed")
, once knative/eventing#2046 is fixed

Creating this so that we don't miss it.
@nachocano nachocano added kind/feature-request New feature or request area/test-and-release Test infrastructure, tests or release priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 and removed kind/feature-request New feature or request labels Mar 13, 2020
@nachocano nachocano mentioned this issue Mar 13, 2020
Closed
16 tasks
@nachocano nachocano added this to the v0.14.0-M2 milestone Mar 18, 2020
@grantr
Copy link
Contributor

grantr commented Mar 18, 2020

knative/eventing#2046 is fixed now.

@ian-mi ian-mi mentioned this issue Mar 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ian-mi ian-mi

Labels
area/test-and-release Test infrastructure, tests or release priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Projects
None yet
Milestone
v0.14.0-M2
Development

Successfully merging a pull request may close this issue.

Add Propagation of W3C HTTP Trace Headers ian-mi/knative-gcp
3 participants
@grantr @nachocano @ian-mi