Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Tracing through Channel #226

Closed
Harwayne opened this issue Aug 29, 2019 · 5 comments
Closed

Tracing through Channel #226

Harwayne opened this issue Aug 29, 2019 · 5 comments
Assignees
Labels
area/observability area/test-and-release Test infrastructure, tests or release lifecycle/stale priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Milestone

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Aug 29, 2019

Problem
A request made to the Channel should generate traces that link the request to the subscribers. It should either use an existing Trace if present, or create a new Trace if one isn't.

The trace from the Channel to any subscribers MUST be annotated with the subscription's name.

Persona:
System Integrator

Exit Criteria
Each of the following generate a trace that includes both the incoming request and the request to any subscribers. The trace from the Channel to any subscribers MUST be annotated with the subscription's name:

  • A request sent to an Channel without any trace information.
  • A request sent to an Channel with trace information in the HTTP headers (B3 format).
  • A request sent to an Channel with trace information in the Cloud Event's traceparent attribute, but not in the HTTP headers.

Note that this is very similar to knative/eventing#1757

@n3wscott
Copy link
Contributor

n3wscott commented Sep 4, 2019

Requires work and testing for PullSubscription and Topic

@Harwayne
Copy link
Contributor Author

/milestone v0.10.0

@knative-prow-robot
Copy link
Contributor

@Harwayne: The provided milestone is not valid for this repository. Milestones in this repository: []

Use /milestone clear to clear the milestone.

In response to this:

/milestone v0.10.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Harwayne
Copy link
Contributor Author

Harwayne commented Oct 8, 2019

/assign

@akashrv akashrv added priority/2 Nice to have feature but doesn't block current release defined by release/* release/1 labels Oct 8, 2019
@ian-mi ian-mi self-assigned this Feb 28, 2020
@nachocano nachocano added the area/test-and-release Test infrastructure, tests or release label Mar 13, 2020
@grantr grantr added this to the Backlog milestone Apr 21, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/observability area/test-and-release Test infrastructure, tests or release lifecycle/stale priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Projects
None yet
Development

No branches or pull requests

7 participants