Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

ENS protocol redirect server #549

Closed
mikehelmick opened this issue Sep 16, 2020 · 5 comments
Closed

ENS protocol redirect server #549

mikehelmick opened this issue Sep 16, 2020 · 5 comments
Assignees
Labels
kind/enhancement New feature or feature request.

Comments

@mikehelmick
Copy link
Contributor

TL;DR

A prototype for this exists in PR #546

The current ens protocol spec is not clickable in all messaging apps that may be used to receive SMS deep links on mobile devices.

In order to ensure that all users have a clickable link, we will provide a redirect server that verification server operators can use to

Design

Proposal

Simple URL redirect service. This needs to support custom subdomain mapping to ENS link.

Having unique subdomains allows per-region applications to to register that intent and handle it in the mobile OS.

As an example.

https://us-wa.example.com/v?c=1234abcd5678efgh

will redirect to

ens://v?c=1234abcd5678efgh&r=US-WA

Configuration will consist of 2 elements
URI prefix to simply rewrite to ens://
and the region to append
will add "&r=REGION"

redirect requests that reach the server and do not match will return a 404.

Alternatives considered

the existing ens:// schema has proven not to work.

Resources

ens protocol spec

Additional information

For production deployment, request logging should be disabled.

/kind enhancement
/assign

@mikehelmick
Copy link
Contributor Author

PR for server itself is #546

Still to do

  • Terraform
  • Update main server w/ instructions for deep links

@mikehelmick
Copy link
Contributor Author

/assign @icco
is going to take on the terraform piece

@sethvargo
Copy link
Member

@icco are there remaining items here that aren't tracked in other issues?

@icco
Copy link
Contributor

icco commented Sep 23, 2020

Nope we should be good here. #613 and #615 we're the last fixes.

/close

@google-oss-robot
Copy link

@icco: Closing this issue.

In response to this:

Nope we should be good here. #613 and #615 we're the last fixes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or feature request.
Projects
None yet
Development

No branches or pull requests

4 participants