Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

https -> ens protocol redirect service #546

Merged
merged 5 commits into from
Sep 16, 2020
Merged

https -> ens protocol redirect service #546

merged 5 commits into from
Sep 16, 2020

Conversation

mikehelmick
Copy link
Contributor

@mikehelmick mikehelmick commented Sep 15, 2020 •
edited
Loading

First towards #549

Proposed Changes

  • Standalone service to redirect https:// links to ens:// for mobile

Release Note

Introduce deep link redirect service to support exposure notification express.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 15, 2020
@mikehelmick
Copy link
Contributor Author

/hold

sethvargo
sethvargo reviewed Sep 15, 2020
View reviewed changes
cmd/enx-redirect/main.go Show resolved Hide resolved
pkg/config/redirect_config.go Outdated Show resolved Hide resolved
pkg/config/redirect_config.go Outdated Show resolved Hide resolved
pkg/controller/redirect/index.go Outdated Show resolved Hide resolved
@mikehelmick mikehelmick mentioned this pull request Sep 16, 2020
Closed
@mikehelmick mikehelmick changed the title [DRAFT] prototype https to ens:// redirector https -> ens protocol redirect service Sep 16, 2020
@mikehelmick
Copy link
Contributor Author

/unhold

flagxor
flagxor approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@flagxor flagxor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Is it overkill to have an explicit list of regions?

cmd/enx-redirect/assets/header.html
}

</style>
{{end}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line ending?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flagxor, mikehelmick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 14187cd into google:main Sep 16, 2020
@google google locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo left review comments

@flagxor flagxor flagxor approved these changes

@icco icco Awaiting requested review from icco

@jeremyfaller jeremyfaller Awaiting requested review from jeremyfaller

Assignees

@flagxor flagxor

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikehelmick @google-oss-robot @sethvargo @flagxor @googlebot