Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Redirector Terraform #558

Merged
merged 14 commits into from
Sep 18, 2020
Merged

Redirector Terraform #558

merged 14 commits into from
Sep 18, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Sep 17, 2020 •
edited
Loading

Continues #549, does not include DNS changes.

Release Note

Adds redirector to terraform services

@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 17, 2020
sethvargo
sethvargo reviewed Sep 17, 2020
View reviewed changes
terraform/service_enx_redirect.tf Outdated Show resolved Hide resolved
builders/build.yaml Outdated Show resolved Hide resolved
@icco icco marked this pull request as ready for review September 17, 2020 16:35
@icco
Copy link
Contributor Author

icco commented Sep 17, 2020

Don't want to merge until @mikehelmick's PRs are in.

/hold
/assign sethvargo

sethvargo
sethvargo reviewed Sep 17, 2020
View reviewed changes
terraform/service_redirect.tf Outdated Show resolved Hide resolved
terraform/variables.tf Outdated Show resolved Hide resolved
sethvargo
sethvargo approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@icco
Copy link
Contributor Author

icco commented Sep 18, 2020

/unhold

@sethvargo sethvargo added the lgtm label Sep 18, 2020
@google-oss-robot google-oss-robot merged commit f5b9e9b into google:main Sep 18, 2020
@icco icco deleted the redir-tf branch September 18, 2020 16:03
@icco icco mentioned this pull request Sep 18, 2020
Merged
@google google locked and limited conversation to collaborators Oct 6, 2020
@icco icco restored the redir-tf branch October 6, 2020 20:52
@icco icco deleted the redir-tf branch October 6, 2020 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

@yegle yegle Awaiting requested review from yegle

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@icco @google-oss-robot @sethvargo @googlebot