Fixed AnimationTrackEditor
redraw/deselect timing and some refactoring
#64980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some weird redraw timings and most of errors by key editing.
Desktop.2022.08.29.-.11.18.15.01.mp4
In some edit commands, deselection and redraw were missing, causing errors in Undo/Redo during key selection. Also, there were many duplicates of the code for redraw, so it is refactored by making it a function.
Additional fixes:
Follow up #64678, track key times are stored as
double
values, but if it storedouble
value directly, the baked animation key finding was failing becauseAnimation::track_find_key()
comparisons are too strict. Fixed it by making baked keys inreal_t
time.1Some little fixes such as following up #64951 (renamed internal variables to more appropriate).
Footnotes
Also, it seems to be that the glTF animation times are baked as
real_t
inGLTFDocument::_serialize_animations()
. If you want to storedouble
values directly, we need to useMath::is_equal_approx()
inAnimation::track_find_key()
↩