Fix optimizer miscalculation and add optimization for Animation::ValueTrack
#64951
+210
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
value-track-optimizer
branch
2 times, most recently
from
9db4fdd to
ee54797
Compare
reduz
approved these changes
Aug 27, 2022
TokageItLab
commented
Aug 27, 2022
| if (!signbit(v0 * v1)) { | ||
| v0 = abs(v0); | ||
| v1 = abs(v1); | ||
| double ratio = v0 < v1 ? v0 / v1 : v1 / v0; |
There was a problem hiding this comment.
In the before method, it does not get the absolute value here, and the positive and negative values are reversed, causing the ratio to be incorrect.
TokageItLab
force-pushed
the
value-track-optimizer
branch
2 times, most recently
from
f5f7a67 to
cb76daf
Compare
|
A little change to the UI around the AnimationTrackEditor optimizer (added a warning comment).
Also, after optimize/clean-up, it clear not only Animation but also AnimationTrackEditor's history. |
TokageItLab
force-pushed
the
value-track-optimizer
branch
from
cb76daf to
f5c49cd
Compare
fire
approved these changes
Aug 27, 2022
TokageItLab
force-pushed
the
value-track-optimizer
branch
from
f5c49cd to
787ab45
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some concerns:
In AnimationEditor, the Edit button can access to optimization from previously, but it is not possible to filter by track type. Also, there is no undo function. This is because the optimization is implemented directly in the
Animationclass. It might be better to implement anAnimationOptimizerclass and usestaticmethods to perform optimizations.