Fix Quaternion Tween and add Easing baker to AnimationTrackEditor #64678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
implement-ease-baker
branch
5 times, most recently
from
ec00743 to
ede0e43
Compare
|
Changed default fps to 30. In addition, Bake as Linear feature is added. Desktop.2022.08.22.-.18.18.45.07.mp4It addresses Cubic Interpolation incompatibilities and performance issues. It can also be used to organize non-uniform keys, and is better used in combination with Optimizer. |
TokageItLab
force-pushed
the
implement-ease-baker
branch
2 times, most recently
from
7af0338 to
06f7991
Compare
TokageItLab
force-pushed
the
implement-ease-baker
branch
from
06f7991 to
f7dd83c
Compare
reduz
approved these changes
Aug 23, 2022
|
Thanks! |
1 task
This was referenced Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop.2022.08.21.-.10.56.00.01.mp4
To improve editing of non-Bezier track animations, add the feature of baking Easing by Tween to the AnimationTrackEditor.
Especially, the ValueTrack has EasingCurve, but the TRS3D track does not have EasingCurve. Is this due to performance reasons or compression tracks @reduz? Well, it is possible to use tween interpolation as an alternative feature from EasingCurve.
The main use case for this feature is to easily add animation to simple skeleton models such as weapons or GUI objects or something. For smoothing in character animation, Cubic interpolation improved with #63380 and #63602 is more appropriate.
In addition, Quaternion tween was completely broken, so this PR fixed it with using slerp internally. Also,
Quaternion::exp()checking algorithm had a problem, which has been fixed.