Invert Camera2D zoom to make it intuitive
#57392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
changed the title
Camera2D zoom to make it intuitive
|
#55731... |
madmiraal
force-pushed
the
implement-3888
branch
from
ab17805 to
0a4be6e
Compare
madmiraal
force-pushed
the
implement-3888
branch
from
0a4be6e to
15ea670
Compare
Closed
akien-mga
approved these changes
Mar 14, 2022
|
Thanks! |
MitchMakesThings
added a commit
to MitchMakesThings/Godot-Things
that referenced
this pull request
Jul 6, 2022
This fixes a crash on startup caused by the new Alpha ignoring old replication configs. Also flipped the camera zoom to match the new camera zoom direction (godotengine/godot#57392 - added in Alpha 5!) Resolves #3
Mickeon
added a commit
to Mickeon/godot
that referenced
this pull request
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in godotengine/godot-proposals#3888, currently,
Camera2D'szoomproperty values are inverted:This PR uses the inverted zoom values to scale objects in the viewport as expected i.e. a zoom of
Vector(2, 2)doubles the size seen in the viewport, and a zoom ofVector(0.5, 0.5)halves the size seen in the viewport:Closes godotengine/godot-proposals#3888.
Supersedes #55731