Revert #57392 & rename Camera zoom
to zoom_scale
#66757
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#5525 (See proposal for further reasoning).
#57392 modified the Camera2D's
zoom
to behave more consistently and intuitively with real-life. Starting fromVector(1, 1)
, Higher values zoom in, and lower values zoom out.It first seemed like a smart move. However, in actual practice, this results in the property being very difficult to work with.
The higher precision of zooming in is essentially not that useful, and zooming out is pretty restrictive.
This PR reverts the change to be like 3.x, and also renames the Camera2D's
zoom
tozoom_scale
as it is already called in the internal code.Do note that this property cannot be added to the Project Converter because it would conflict with GraphEdit's
zoom
, which in truth, also suffers from the same issue. It probably should be there changed, as well.