Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #57392 & rename Camera zoom to zoom_scale #66757

Closed
wants to merge 1 commit into from

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Oct 2, 2022

Closes godotengine/godot-proposals#5525 (See proposal for further reasoning).

#57392 modified the Camera2D's zoom to behave more consistently and intuitively with real-life. Starting from Vector(1, 1), Higher values zoom in, and lower values zoom out.
It first seemed like a smart move. However, in actual practice, this results in the property being very difficult to work with.
The higher precision of zooming in is essentially not that useful, and zooming out is pretty restrictive.

This PR reverts the change to be like 3.x, and also renames the Camera2D's zoom to zoom_scale as it is already called in the internal code.

Do note that this property cannot be added to the Project Converter because it would conflict with GraphEdit's zoom, which in truth, also suffers from the same issue. It probably should be there changed, as well.

@Mickeon Mickeon requested review from a team as code owners October 2, 2022 10:01
@Zireael07
Copy link
Contributor

Do we have other reports that this makes the functionality more difficult to work with?

@Mickeon
Copy link
Contributor Author

Mickeon commented Oct 2, 2022

Doesn't have to be anything urgent, so let's give it time. This PR exists just to address it swiftly if there ends up being demand for it. Most casual users probably don't even realise this has been changed during the transition.

@ettiSurreal
Copy link
Contributor

Doesn't have to be anything urgent, so let's give it time. This PR exists just to address it swiftly if there ends up being demand for it. Most casual users probably don't even realise this has been changed during the transition.

I agree, for now let's just wait and see if others have issues with it aswell.
If it does go through, we could maybe even support zoom_scale of zero, as in rendering only a single row of pixels.

@ettiSurreal
Copy link
Contributor

Since some users seem to prefer the 4.0 behavior, i tried making a solution that hopefully gets the best of both worlds :)
godotengine/godot-proposals#5532

@akien-mga
Copy link
Member

There's no consensus on this PR nor the proposal, so we won't do this change for 4.0.

@akien-mga akien-mga closed this Jan 24, 2023
@Mickeon Mickeon deleted the revert-camera-zoom branch February 11, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invert Camera2D zoom back to Godot 3 behavior
5 participants