Reverse Camera2D zoom #55731
Closed
Reverse Camera2D zoom #55731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation should be updated too. godot/doc/classes/Camera2D.xml Lines 157 to 159 in e53e357 |
Xrayez
reviewed
Dec 9, 2021
| Point2 old_smoothed_camera_pos = smoothed_camera_pos; | ||
| _update_scroll(); | ||
| smoothed_camera_pos = old_smoothed_camera_pos; | ||
| }; | ||
|
|
||
| Vector2 Camera2D::get_zoom() const { | ||
| return zoom; | ||
| return Vector2(1, 1) / zoom; |
There was a problem hiding this comment.
What happens if zoom == Vector2(0, 0) ?
There was a problem hiding this comment.
It can't, unless you somehow set it outside setter.
madmiraal
reviewed
Jan 29, 2022
| Point2 old_smoothed_camera_pos = smoothed_camera_pos; | ||
| _update_scroll(); | ||
| smoothed_camera_pos = old_smoothed_camera_pos; | ||
| }; | ||
|
|
||
| Vector2 Camera2D::get_zoom() const { | ||
| return zoom; | ||
| return Vector2(1, 1) / zoom; |
There was a problem hiding this comment.
Won't this cause a rounding error?
Vector2(1, 1) / (Vector2(1, 1) / zoom) does not always equal to zoom.
There was a problem hiding this comment.
You are right. You PR is probably better then.
|
Closing in favor of #57392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugsquad edit: Implements and closes godotengine/godot-proposals#3888
This PR changes how
zoomproperty of Camera2D works, so e.g. "zoom = 2" is now "zoom-in 2x", which is much more intuitive (previously it would zoom out).Alternatively we could rename the property to
view_rect_scaleor similar, because that's what it actually does right now.