[macOS] Implement seamless display scaling. #40084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
commented
Jul 3, 2020
|
Fixes #5688 I presume? |
bruvzg
force-pushed
the
macos_seamless_scaling
branch
from
daf33d6 to
3cebfa9
Compare
Yes |
Calinou
reviewed
Jul 3, 2020
bruvzg
force-pushed
the
macos_seamless_scaling
branch
from
3cebfa9 to
3bf006d
Compare
bruvzg
force-pushed
the
macos_seamless_scaling
branch
3 times, most recently
from
a208dd7 to
2b4875a
Compare
bruvzg
changed the title
bruvzg
force-pushed
the
macos_seamless_scaling
branch
from
2b4875a to
df968d5
Compare
|
Thanks hugely! |
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 8, 2020
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the highest display scale to calculate window/screen coordinates and for rendering,
downscale(we do not need to do it ourselves, just let OS to do the job) on lower scale displays. Also, should fix popup positions.Before (moving from hiDPI to lowDPI display):
After:
Fixes #5688 (no scale changes when moving from screen to screen)
Fixes #13017 (incorrect project window position when started from editor and project have different DPI settings).
Update:
No Focusflag implementation.window_...andscreen_...functions in the DS, exceptwindow_set_input_text_callback(callback is not used on any desktop platform) andwindow_set_transient(I have no idea what it is really supposed to do), everything seems to work.