Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileSet editor toolbar icons look blurry on non-HiDPI monitor #41839

Open
timothyqiu opened this issue Sep 7, 2020 · 6 comments
Open

TileSet editor toolbar icons look blurry on non-HiDPI monitor #41839

timothyqiu opened this issue Sep 7, 2020 · 6 comments

Comments

@timothyqiu
Copy link
Member

Godot version: 3.2.3 beta 1 ~ rc 5

OS/device including version:
MacBook Pro (Retina, 13-inch, Early 2015)
Intel Iris Graphics 6100 1536 MB

Issue description:

When using both a non-HiDPI and a HiDPI monitor and the Godot Editor is on the non-HiDPI one, the same icon looks blurry on TileSet toolbar buttons, but sharp on other buttons.

This does not happen on the HiDPI monitor, or when only the non-HiDPI monitor is used.

Snapshot on non-HiDPI monitor (the right one looks blurry):

non-hidpi

Snapshot on HiDPI monitor (looks the same):

hidpi

Steps to reproduce:

  1. Use both a HiDPI monitor and a non-HiDPI monitor, and make sure that the Godot Editor is on the non-HiDPI one
  2. Create a new TileSet to open the TileSet editor
  3. Create a tile
  4. Compare the two "trash can" icons.

Minimal reproduction project: Not project related.

@timothyqiu
Copy link
Member Author

After more experiments, I think this may be related to fonts & texts.

The snapshots above is using the zh_CN locale and Noto Sans CJK SC Regular font at size 15.

With the default en locale, the two trash can buttons look differently:

  • At default size 14, the icon on the toolbar looks sharper
    14

  • At size 17, the icon on the toolbar looks best
    17

  • At size 18, both the icons look blurry
    18

@Calinou
Copy link
Member

Calinou commented Sep 7, 2020

Does this occur with other editor icons or the general rendering? Check the 3D viewport's appearance with antialiasing disabled.

cc @bruvzg

@timothyqiu
Copy link
Member Author

It's hard to find duplicated icons to compare the blurriness, but the first TileMap icon here is definitely sharper than the other two:

tilemap-icon

The 3D viewport's appearance is sharp. (Grid lines, gizmos, etc...)


Not sure if it's related, but the size of some image icons in the FileSystem panel are bigger when a HiDPI monitor is available.

With no HiDPI monitor:
no-hidpi

With HiDPI monitor available:
hidpi-available

@bruvzg
Copy link
Member

bruvzg commented Sep 7, 2020

It's side effect of the #40084, if there's HiDPI monitor in the system, everything is rendered at the higher resolution and downscale (by OS) for the LoDPI monitors.

@Calinou
Copy link
Member

Calinou commented Aug 11, 2022

Can you test this with the latest master branch which includes #63957?

@timothyqiu
Copy link
Member Author

Tested on alpha14, still blurry.

截屏2022-08-11 20 03 20

截屏2022-08-11 20 03 14

@Calinou Calinou added this to the 4.x milestone Feb 16, 2023
@Calinou Calinou removed this from the 4.x milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants