Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli commands to regen hooks & keys #3979

Merged
merged 4 commits into from
May 17, 2018
Merged

Add cli commands to regen hooks & keys #3979

merged 4 commits into from
May 17, 2018

Conversation

techknowlogick
Copy link
Member

Rewrite authorized_keys and hooks from command line

Fix #2491

@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 16, 2018
@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #3979 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3979   +/-   ##
=======================================
  Coverage   20.08%   20.08%           
=======================================
  Files         146      146           
  Lines       29867    29867           
=======================================
  Hits         6000     6000           
  Misses      22961    22961           
  Partials      906      906

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfc401...a4bb16d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2018
cmd/admin.go Outdated
@@ -195,3 +216,19 @@ func getReleaseCount(id int64) (int64, error) {
},
)
}

func runRegenerateHooks(c *cli.Context) error {
err := models.SyncRepositoryHooks()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just return models.SyncRepositoryHooks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JonasFranzDEV I've made this change, and the other change you requested.

cmd/admin.go Outdated
}

func runRegenerateKeys(c *cli.Context) error {
err := models.RewriteAllPublicKeys()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just return models.RewriteAllPublicKeys

@techknowlogick techknowlogick changed the title [WIP] Add cli commands to regen hooks & keys Add cli commands to regen hooks & keys May 16, 2018
@techknowlogick techknowlogick added this to the 1.5.0 milestone May 16, 2018
@lunny
Copy link
Member

lunny commented May 17, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2018
@appleboy appleboy merged commit 8176345 into go-gitea:master May 17, 2018
@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label May 17, 2018
@lafriks
Copy link
Member

lafriks commented May 17, 2018

@techknowlogick please add this commands also to docs page (cli)

@lafriks
Copy link
Member

lafriks commented May 17, 2018

@appleboy please do not merge while all reviewers has not approved, it this case probably it was not so important but it's better to follow this rule even if requested changes was fixed

@lunny
Copy link
Member

lunny commented May 17, 2018

yes @appleboy, @JonasFranzDEV didn't approve.

@appleboy
Copy link
Member

@lunny @lafriks OK, I forgot @JonasFranzDEV didn't approve.

@techknowlogick
Copy link
Member Author

@lafriks I've added these docs to https://docs.gitea.io/en-us/command-line/ already, is there another place that they need to be?

@lafriks
Copy link
Member

lafriks commented May 17, 2018

@techknowlogick yes that what I mean, false alarm, all is good :)

aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite authorized_keys and hooks from command line (feature request)
8 participants