Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow square brackets in external issue patterns #3408

Merged
merged 3 commits into from
Feb 3, 2018
Merged

Allow square brackets in external issue patterns #3408

merged 3 commits into from
Feb 3, 2018

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Jan 25, 2018

Many projects write the issue reference in square brackets, like [JIRA-123] or [#123]. This PR makes the external issue pattern support this as well.

sapk
sapk approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
The CI fail seems not related.
You can restart it via a commit amend or maybe a owner can restart the build.

modules/markup/html_test.go
@@ -342,6 +342,7 @@ func TestRegExp_IssueNumericPattern(t *testing.T) {
"#1234",
"#0",
"#1234567890987654321",
"[#1234]",
}
falseTestCases := []string{
"# 1234",
Copy link
Member

@sapk sapk Jan 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, I would add to falseTestCases [] [X] that are checklist element even if there should be replace before by markdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test cases

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2018
@lafriks
Copy link
Member

lafriks commented Jan 26, 2018 •
edited
Loading

Doesn't this interfere with links for example, [PR-121](http://example.com) ?

@lunny lunny added this to the 1.5.0 milestone Jan 28, 2018
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 28, 2018
@derkoe
Copy link
Contributor Author

derkoe commented Jan 28, 2018

Links are handled before the issue patterns in RenderSpecialLink - I think this should not interfere

@thehowl
Copy link
Contributor

thehowl commented Jan 30, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #3408 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3408      +/-   ##
==========================================
- Coverage    35.6%   35.58%   -0.02%     
==========================================
  Files         281      281              
  Lines       40586    40586              
==========================================
- Hits        14450    14443       -7     
- Misses      23999    24006       +7     
  Partials     2137     2137
Impacted Files Coverage Δ
modules/markup/html.go 54.56% <ø> (ø) ⬆️
modules/indexer/indexer.go 70% <0%> (-7.5%) ⬇️
models/repo_indexer.go 42.03% <0%> (-3.99%) ⬇️
models/repo.go 43.17% <0%> (+0.18%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08b3a5...339b299. Read the comment docs.

@lafriks lafriks merged commit e9e2a9c into go-gitea:master Feb 3, 2018
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Jul 3, 2018
aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
@aswild
Merge tag 'v1.5.0-rc1' into wild/v1.5
9b336e6 
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
8 participants
@derkoe @lafriks @thehowl @codecov-io @sapk @lunny @tboerger @delvh