Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve release page UI #3693

Merged
merged 3 commits into from
Mar 19, 2018
Merged

Improve release page UI #3693

merged 3 commits into from
Mar 19, 2018

Conversation

jonasfranz
Copy link
Member

@jonasfranz jonasfranz commented Mar 19, 2018 •
edited
Loading

Improve the release page UI by

  • adding the file size
  • change the icon from desktop-download to package
  • make download title bold

Screenshot

Release with 4 attachments

@jonasfranz
Improve release page ui by adding size
e428b3c 
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz changed the title Improve release page ui by adding size Improve release page UI Mar 19, 2018
@jonasfranz
Add documentation to a.MustSize()
45f6b65 
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@codecov-io
Copy link

codecov-io commented Mar 19, 2018 •
edited
Loading

Codecov Report

Merging #3693 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage    35.8%   35.79%   -0.02%     
==========================================
  Files         287      287              
  Lines       41489    41496       +7     
==========================================
- Hits        14854    14852       -2     
- Misses      24447    24456       +9     
  Partials     2188     2188
Impacted Files Coverage Δ
models/attachment.go 44.52% <0%> (-2.25%) ⬇️
models/repo_list.go 56.37% <0%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47422c2...ffa8d2f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2018
@lunny lunny added the type/bug label Mar 19, 2018
@lunny lunny added this to the 1.5.0 milestone Mar 19, 2018
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2018
@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed type/bug lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2018
@jonasfranz jonasfranz closed this Mar 19, 2018
@jonasfranz jonasfranz reopened this Mar 19, 2018
@lunny
Copy link
Member

lunny commented Mar 19, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2018
@lafriks lafriks merged commit 43fc430 into go-gitea:master Mar 19, 2018
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Mar 19, 2018
@jonasfranz jonasfranz deleted the improve-release-page branch March 19, 2018 17:57
aswild added a commit to aswild/gitea that referenced this pull request Jul 6, 2018
@aswild
Merge tag 'v1.5.0-rc1' into wild/v1.5
9b336e6 
* SECURITY
  * Limit uploaded avatar image-size to 4096x3072 by default (go-gitea#4353)
  * Do not allow to reuse TOTP passcode (go-gitea#3878)
* FEATURE
  * Add cli commands to regen hooks & keys (go-gitea#3979)
  * Add support for FIDO U2F (go-gitea#3971)
  * Added user language setting (go-gitea#3875)
  * LDAP Public SSH Keys synchronization (go-gitea#1844)
  * Add topic support (go-gitea#3711)
  * Multiple assignees (go-gitea#3705)
  * Add protected branch whitelists for merging (go-gitea#3689)
  * Global code search support (go-gitea#3664)
  * Add label descriptions (go-gitea#3662)
  * Add issue search via API (go-gitea#3612)
  * Add repository setting to enable/disable health checks (go-gitea#3607)
  * Emoji Autocomplete (go-gitea#3433)
  * Implements generator cli for secrets (go-gitea#3531)
* ENHANCEMENT
  * Add more webhooks support and refactor webhook templates directory (go-gitea#3929)
  * Add new option to allow only OAuth2/OpenID user registration (go-gitea#3910)
  * Add option to use paged LDAP search when synchronizing users (go-gitea#3895)
  * Symlink icons (go-gitea#1416)
  * Improve release page UI (go-gitea#3693)
  * Add admin dashboard option to run health checks (go-gitea#3606)
  * Add branch link in branch list (go-gitea#3576)
  * Reduce sql query times in retrieveFeeds (go-gitea#3547)
  * Option to enable or disable swagger endpoints (go-gitea#3502)
  * Add missing licenses (go-gitea#3497)
  * Reduce repo indexer disk usage (go-gitea#3452)
  * Enable caching on assets and avatars (go-gitea#3376)
  * Add repository search ordered by stars/forks. Forks column in admin repo list (go-gitea#3969)
  * Add Environment Variables to Docker template (go-gitea#4012)
  * LFS: make HTTP auth period configurable (go-gitea#4035)
  * Add config path as an optionial flag when changing pass via CLI (go-gitea#4184)
  * Refactor User Settings sections (go-gitea#3900)
  * Allow square brackets in external issue patterns (go-gitea#3408)
  * Add Attachment API (go-gitea#3478)
  * Add EnableTimetracking option to app settings (go-gitea#3719)
  * Add config option to enable or disable log executed SQL (go-gitea#3726)
  * Shows total tracked time in issue and milestone list (go-gitea#3341)
* TRANSLATION
  * Improve English grammar and consistency (go-gitea#3614)
* DEPLOYMENT
  * Allow Gitea to run as different USER in Docker (go-gitea#3961)
  * Provide compressed release binaries (go-gitea#3991)
  * Sign release binaries (go-gitea#4188)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jonasfranz @codecov-io @lunny @appleboy @tboerger @lafriks @delvh