Allow to disable the password-based login (sign-in) form #32687
Merged
+73
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/go
This was referenced Dec 1, 2024
wxiaoguang
force-pushed
the
supprt-enable-password-form
branch
from
cbaad1d to
86dd4ac
Compare
|
This is perfect! Can’t wait because this is basicly a security measure as well. Thanks :-) |
wxiaoguang
added
the
type/feature
delvh
approved these changes
Dec 1, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
changed the title
lunny
approved these changes
Dec 1, 2024
GiteaBot
added
lgtm/done
lunny
approved these changes
Dec 2, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 2, 2024
* giteaofficial/main: Refactor RepoBranchTagSelector (go-gitea#32681) Allow to disable the password-based login (sign-in) form (go-gitea#32687) Fix JS error when reply comment on Conversation page (go-gitea#32685) fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings (go-gitea#32668)
|
Need to fix a regression: Fix oauth2 login methods #32698 |
lunny
pushed a commit
that referenced
this pull request
Dec 3, 2024
Regression of #32687 It should use "or" but not "and", otherwise the oauth2 methods won't show when no ENABLE_OPENID_SIGNIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually enterprise/organization users would like to only allow OAuth2 login.
This PR adds a new config option to disable the password-based login form. It is a simple and clear approach and won't block the future login-system refactoring works.
https://gitea.com/gitea/docs/pulls/110
Fix a TODO in #24821
Replace #21851
Close #7633 , close #13606
Screenshots: