Refactor RepoBranchTagSelector #32681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/templates
wxiaoguang
force-pushed
the
refactor-branch-dropdown
branch
from
d0b7624 to
3a548cb
Compare
wxiaoguang
force-pushed
the
refactor-branch-dropdown
branch
from
3a548cb to
e82471b
Compare
delvh
approved these changes
Nov 30, 2024
GiteaBot
added
lgtm/need 1
metiftikci
reviewed
Dec 1, 2024
| {{template "repo/branch_dropdown" dict | ||
| "Repository" .Repository | ||
| "ShowTabBranches" true | ||
| "CurrentRefType" "branch" |
There was a problem hiding this comment.
looks like start showing from branch tab is not correct. when i want to see source from tag, dropdown button still shows branch name
There was a problem hiding this comment.
Nope, this selector is used to choose the base branch to receive a cherry-pick commit. It is not used for "source of tags".
This is the same behavior as old code, old code used "noTag" true to disable the tag tab and only show branch tab.
lunny
approved these changes
Dec 2, 2024
GiteaBot
added
lgtm/done
lunny
added
the
type/refactoring
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 2, 2024
* giteaofficial/main: Refactor RepoBranchTagSelector (go-gitea#32681) Allow to disable the password-based login (sign-in) form (go-gitea#32687) Fix JS error when reply comment on Conversation page (go-gitea#32685) fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings (go-gitea#32668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepoBranchTagSelector seems to be the dirtiest code ever and one of hardest JS modules to touch, a lot of unrelated things were mixed together.
To make it maintainable and easy to add more features, rewrite it.
It is still not perfect due to some legacy problems (for example: pass data into the sfc), overall it is much better than before (and jQuery is also removed)
Manually tested:
Repo Home:
Commits page:
Release page:
Commit Cherry-pick: