Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the same translation keystrings for the same labels in milestone dropdown menus #32667

Closed
SimonPistache opened this issue Nov 28, 2024 · 1 comment · Fixed by #32668
Closed

Reuse the same translation keystrings for the same labels in milestone dropdown menus #32667

SimonPistache opened this issue Nov 28, 2024 · 1 comment · Fixed by #32668
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@SimonPistache
Copy link
Contributor

SimonPistache commented Nov 28, 2024 •
edited
Loading

Description

I noticed the Milestone dropdown selector used in the sidebar of an issue/PR doesn't use the same translation keystring as the ones used in the filters and actions menubars

Keystring used in the sidebar

Screenshot 2024-11-28 at 17-10-27

Keystring used in the actionbar & filterbar

Screenshot 2024-11-28 at 17-09-56

Screenshot 2024-11-28 at 17-18-41

Further more, the actions menubars misuses the 'open' keystring for both opened and closed milestones, whereas it should use the 'close' keystring.

Screenshots

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Macos

Browser Version

Firefox 132
@SimonPistache SimonPistache added topic/ui Change the appearance of the Gitea UI type/bug labels Nov 28, 2024
@SimonPistache
Copy link
Contributor Author

SimonPistache commented Nov 28, 2024 •
edited
Loading

Suggested changes:

  • Fix the off-label about closed milestones on the actionbar dropdown
  • Change keystrings used in the sidebar to reuse the ones used in the actionbar and the filterbar
  • Remove the now unused keystrings (idk how crowdin handle keystring deletions in the code)

SimonPistache added a commit to SimonPistache/gitea that referenced this issue Nov 28, 2024
@SimonPistache
fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicate…
b7f2128 
…s keystrings

- Fixe a translation keystring misuse where the string 'open milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones' keystrings on the sidebar of an issue, reusing the ones on the issues filter and action bars.
@SimonPistache SimonPistache mentioned this issue Nov 28, 2024
Merged
zjjhot added a commit to zjjhot/gitea that referenced this issue Dec 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5ebe735 
* giteaofficial/main:
  Refactor RepoBranchTagSelector (go-gitea#32681)
  Allow to disable the password-based login (sign-in) form (go-gitea#32687)
  Fix JS error when reply comment on Conversation page (go-gitea#32685)
  fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings (go-gitea#32668)
lunny pushed a commit to lunny/gitea that referenced this issue Dec 11, 2024
@SimonPistache @wxiaoguang @lunny
fix(go-gitea#32667): 🐛 Fixe a keystring misuse and refactor duplicate…
d92c96a 
…s keystrings (go-gitea#32668)

- Fixes a translation keystring misuse where the string 'open
milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones'
keystrings on the sidebar of an issue, reusing the ones on the issues
filter and action bars.
- Closes go-gitea#32667

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny mentioned this issue Dec 11, 2024
Merged
techknowlogick pushed a commit that referenced this issue Dec 11, 2024
@lunny @SimonPistache @wxiaoguang
🐛 Fixe a keystring misuse and refactor duplicates keystrings (#32668) (…
6092bba 
…#32792)

Backport #32668 

- Fixes a translation keystring misuse where the string 'open
milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones'
keystrings on the sidebar of an issue, reusing the ones on the issues
filter and action bars.
- Closes #32667

Co-authored-by: Simon Pistache <105607989+SimonPistache@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#32667): 🐛 Fixe a keystring misuse and refactor duplicates keystrings SimonPistache/gitea
1 participant
@SimonPistache