Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox bug on private/archive filter #32236

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix checkbox bug on private/archive filter #32236

merged 3 commits into from
Oct 10, 2024

Conversation

cloudchamb3r
Copy link
Contributor

fix #32235

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 10, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2024
delvh
delvh reviewed Oct 10, 2024
View reviewed changes
web_src/js/components/DashboardRepoList.vue Outdated Show resolved Hide resolved
web_src/js/components/DashboardRepoList.vue Outdated Show resolved Hide resolved
web_src/js/components/DashboardRepoList.vue Outdated Show resolved Hide resolved
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 10, 2024 •
edited
Loading

It is a regression of " Remove fomantic checkbox module #30162 " because Fomantic UI uses "hidden (z-index: -1)" class to make the checkbox work correctly, see the comments in code.

Without Fomantic UI's "hidden" class, I think it could be something like class="tw-pointer-events-none"

And, the comments should be removed updated to explain why it needs the pointer-events: none

@cloudchamb3r cloudchamb3r force-pushed the fix/repo-filter-input-no-select branch from 5c37067 to 0784258 Compare October 10, 2024 17:01
@cloudchamb3r
Copy link
Contributor Author

Thanks for your advice. I applied it to my code.

@cloudchamb3r @wxiaoguang
edit comments
4180fec 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2024
@wxiaoguang wxiaoguang merged commit cb739f5 into go-gitea:main Oct 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 10, 2024
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Oct 10, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
58fd331 
* giteaofficial/main:
  Fix checkbox bug on private/archive filter (go-gitea#32236)
  Improve the maintainblity of the reserved username list (go-gitea#32229)
  Move admin routers from /admin to /-/admin (go-gitea#32189)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 11, 2024
@cloudchamb3r @wxiaoguang @GiteaBot
Fix checkbox bug on private/archive filter (go-gitea#32236)
534c167 
fix go-gitea#32235

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this pull request Oct 11, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 11, 2024
wxiaoguang added a commit that referenced this pull request Oct 11, 2024
@GiteaBot @cloudchamb3r @wxiaoguang
Fix checkbox bug on private/archive filter (#32236) (#32240)
f15d5f0 
Backport #32236 by cloudchamb3r

fix #32235

Co-authored-by: cloudchamb3r <jizon0123@protonmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Input bug on repository archive/private filter checkbox
4 participants
@cloudchamb3r @wxiaoguang @delvh @GiteaBot