Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scheduled tasks even if changes are pushed by "ActionsUser" #32246

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Update scheduled tasks even if changes are pushed by "ActionsUser" #32246

merged 4 commits into from
Oct 13, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #32219

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 12, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 12, 2024
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 12, 2024
delvh
delvh approved these changes Oct 12, 2024
View reviewed changes
services/actions/notifier_helper.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 12, 2024
@Zettat123 @delvh
Update services/actions/notifier_helper.go
088a01f 
Co-authored-by: delvh <dev.lh@web.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 13, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 13, 2024
@lunny lunny enabled auto-merge (squash) October 13, 2024 20:04
@lunny lunny merged commit 81aec6d into go-gitea:main Oct 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 13, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.22. @Zettat123, please send one manually. 🍵

go run ./contrib/backport 32246
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 13, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Oct 13, 2024
Zettat123 added a commit to Zettat123/gitea that referenced this pull request Oct 14, 2024
@Zettat123 @delvh
Update scheduled tasks even if changes are pushed by "ActionsUser" (g…
1a84f7a 
…o-gitea#32246)

Fix go-gitea#32219

---------

Co-authored-by: delvh <dev.lh@web.de>
@Zettat123 Zettat123 mentioned this pull request Oct 14, 2024
Merged
wolfogre pushed a commit that referenced this pull request Oct 14, 2024
@Zettat123 @delvh
Update scheduled tasks even if changes are pushed by "ActionsUser" (#…
55562f9 
…32246) (#32252)

Backport #32246

Fix #32219

Co-authored-by: delvh <dev.lh@web.de>
@Zettat123 Zettat123 added the backport/done All backports for this PR have been created label Oct 15, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
88e59ef 
* giteaofficial/main:
  Make `owner/repo/pulls` handlers use "PR reader" permission (go-gitea#32254)
  make `show stats` work when only one file changed (go-gitea#32244)
  Update scheduled tasks even if changes are pushed by "ActionsUser" (go-gitea#32246)
  Support migrating GitHub/GitLab PR draft status (go-gitea#32242)
  Only rename a user when they should receive a different name (go-gitea#32247)
  Fix dropdown content overflow (go-gitea#31610)
  Make git push options accept short name (go-gitea#32245)
  Allow code search by filename (go-gitea#32210)
  Allow maintainers to view and edit files of private repos when "Allow maintainers to edit" is enabled (go-gitea#32215)
  Use per package global lock for container uploads instead of memory lock (go-gitea#31860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Gitea Action didn't use last commit when action is triggered by schdule
4 participants
@Zettat123 @GiteaBot @lunny @delvh