Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always update expiration time when creating an artifact #32281

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Always update expiration time when creating an artifact #32281

merged 4 commits into from
Oct 17, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #32256

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 17, 2024
@Zettat123 Zettat123 added type/bug topic/gitea-actions related to the actions of Gitea labels Oct 17, 2024
@techknowlogick techknowlogick added the backport/v1.22 This PR should be backported to Gitea 1.22 label Oct 17, 2024
@lunny lunny requested a review from fuxiaohei October 17, 2024 04:04
@Zettat123
Copy link
Contributor Author

Zettat123 commented Oct 17, 2024 •
edited
Loading

I noticed another issue. If we re-run a job, the storage path of the old artifact will be overwritten by the storage path of the newly created artifact, which may cause the old artifact to never be cleaned up.

No problem. It has been fixed by #28726

@Zettat123 Zettat123 marked this pull request as draft October 17, 2024 04:26
@Zettat123 Zettat123 marked this pull request as ready for review October 17, 2024 04:40
yp05327
yp05327 reviewed Oct 17, 2024
View reviewed changes
models/actions/artifact.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 17, 2024
@lunny lunny enabled auto-merge (squash) October 17, 2024 08:35
@lunny lunny merged commit 9116665 into go-gitea:main Oct 17, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 17, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.22. @Zettat123, please send one manually. 🍵

go run ./contrib/backport 32281
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 17, 2024
Zettat123 added a commit to Zettat123/gitea that referenced this pull request Oct 17, 2024
@Zettat123
Always update expiration time when creating an artifact (go-gitea#32281)
304639c 
Fix go-gitea#32256
@Zettat123 Zettat123 mentioned this pull request Oct 17, 2024
Merged
lunny pushed a commit that referenced this pull request Oct 18, 2024
@Zettat123
Always update expiration time when creating an artifact (#32281) (#32285
99cac1f 
)

Backport #32281

Fix #32256
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Oct 20, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 21, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8e4adf4 
* giteaofficial/main:
  API: enhance SearchIssues swagger docs (go-gitea#32208)
  Update github.com/go-enry/go-enry to v2.9.1 (go-gitea#32295)
  Always update expiration time when creating an artifact (go-gitea#32281)
  Add `gh-access-token` flag into backport script (go-gitea#32283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@fuxiaohei fuxiaohei Awaiting requested review from fuxiaohei

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Artifacts get lost, when re-running old workflows
6 participants
@Zettat123 @GiteaBot @lunny @wolfogre @yp05327 @techknowlogick