Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show View at this point in history for every commit #29122

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Show View at this point in history for every commit #29122

merged 7 commits into from
Feb 13, 2024

Conversation

zokkis
Copy link
Contributor

@zokkis zokkis commented Feb 9, 2024

Shows the 'View at this point in history'-link (from #27354) for every commit

before:
image

after:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 9, 2024
@delvh delvh changed the title Shows 'View at this point in history'-link for every commit Show View at this point in history for every commit Feb 9, 2024
@zokkis zokkis mentioned this pull request Feb 9, 2024
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2024
@zokkis
Copy link
Contributor Author

zokkis commented Feb 12, 2024

Do I have to 'Update branch' or something? Because it has 2 approvals but I cant merge

@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 12, 2024
@KN4CK3R KN4CK3R merged commit b85e4a6 into go-gitea:main Feb 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 13, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 13, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 13, 2024

Users can't merge their PRs.

@zokkis zokkis deleted the enhancement/show-always-view-path branch February 13, 2024 08:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
82aedae 
* giteaofficial/main: (38 commits)
  Document how the TOC election process works (go-gitea#29135)
  Runner tokens are multi use (go-gitea#29153)
  Fix Gitpod logic of setting ROOT_URL (go-gitea#29162)
  Remove jQuery from the user search form in admin page (go-gitea#29151)
  Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551)
  Show `View at this point in history` for every commit (go-gitea#29122)
  [skip ci] Updated translations via Crowdin
  Add merge style `fast-forward-only` (go-gitea#28954)
  Use Markdown alert syntax for notes in README (go-gitea#29150)
  Refactor issue template parsing and fix API endpoint (go-gitea#29069)
  [skip ci] Updated translations via Crowdin
  Update some translations and fix markdown formatting (go-gitea#29099)
  Show more settings for empty repositories (go-gitea#29130)
  Update JS and PY dependencies (go-gitea#29127)
  Add alert blocks in markdown (go-gitea#29121)
  Remove obsolete border-radius on comment content (go-gitea#29128)
  Make blockquote border size less aggressive (go-gitea#29124)
  Drop "@" from email sender to avoid spam filters (go-gitea#29109)
  [skip ci] Updated translations via Crowdin
  Disallow duplicate storage paths (go-gitea#26484)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 15, 2024
@zokkis @silverwind
Show View at this point in history for every commit (go-gitea#29122)
de2add3 
Shows the 'View at this point in history'-link (from go-gitea#27354) for every
commit

before:

![image](https://github.com/go-gitea/gitea/assets/72873130/0e5cd763-e099-4bb4-9519-653fe21f85a6)

after:

![image](https://github.com/go-gitea/gitea/assets/72873130/2b57346f-51e3-4901-b85e-63a690878939)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@zokkis @silverwind
Show View at this point in history for every commit (go-gitea#29122)
7e92353 
Shows the 'View at this point in history'-link (from go-gitea#27354) for every
commit

before:

![image](https://github.com/go-gitea/gitea/assets/72873130/0e5cd763-e099-4bb4-9519-653fe21f85a6)

after:

![image](https://github.com/go-gitea/gitea/assets/72873130/2b57346f-51e3-4901-b85e-63a690878939)
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
@zokkis @earl-warren
Show View at this point in history for every commit (go-gitea#29122)
27bc2b9 
Shows the 'View at this point in history'-link (from go-gitea#27354) for every
commit

before:

![image](https://github.com/go-gitea/gitea/assets/72873130/0e5cd763-e099-4bb4-9519-653fe21f85a6)

after:

![image](https://github.com/go-gitea/gitea/assets/72873130/2b57346f-51e3-4901-b85e-63a690878939)

(cherry picked from commit b85e4a6)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
@go-gitea go-gitea unlocked this conversation Apr 3, 2024
@wxiaoguang
Copy link
Contributor

Actually I have a question for this change: if there is no FileName, why it should show a link to the commit? The commit link is already shown in the second column. If I understand correctly, View at this point in history is only for viewing a "file", but not a "commit". I think this change is not right.

wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Apr 5, 2024
@wxiaoguang
Revert "Show View at this point in history for every commit (go-gitea…
db73904 
…#29122)"
@wxiaoguang wxiaoguang mentioned this pull request Apr 5, 2024
Closed
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 5, 2024 •
edited
Loading

-> Revert "Show View at this point in history for every commit (#29122)" #30295

Sorry for my misundestanding and sorry for bothering, the new PR: -> https://github.com/go-gitea/gitea/pull/30297/files?diff=split&w=1

@wxiaoguang wxiaoguang mentioned this pull request Apr 5, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zokkis @KN4CK3R @wxiaoguang @delvh @GiteaBot