Show more settings for empty repositories #29130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
the
modifies/templates
zokkis
changed the title
|
In other words, reverts #28631? |
|
As I already mentioned in the PR above, the best approach would probably be to disable the settings and display a tooltip why it is disabled. |
No its not a revert And enable this setting on a empty repo shows the settings |
Then this should be work for all settings like
|
wxiaoguang
approved these changes
Feb 11, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Feb 11, 2024
GiteaBot
added
lgtm/done
|
Regarding my previous comment: I misunderstood you, I thought you meant showing all settings even when code is disabled. Not for empty repos. |
delvh
added
type/enhancement
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 14, 2024
* giteaofficial/main: (38 commits) Document how the TOC election process works (go-gitea#29135) Runner tokens are multi use (go-gitea#29153) Fix Gitpod logic of setting ROOT_URL (go-gitea#29162) Remove jQuery from the user search form in admin page (go-gitea#29151) Dont load Review if Comment is CommentTypeReviewRequest (go-gitea#28551) Show `View at this point in history` for every commit (go-gitea#29122) [skip ci] Updated translations via Crowdin Add merge style `fast-forward-only` (go-gitea#28954) Use Markdown alert syntax for notes in README (go-gitea#29150) Refactor issue template parsing and fix API endpoint (go-gitea#29069) [skip ci] Updated translations via Crowdin Update some translations and fix markdown formatting (go-gitea#29099) Show more settings for empty repositories (go-gitea#29130) Update JS and PY dependencies (go-gitea#29127) Add alert blocks in markdown (go-gitea#29121) Remove obsolete border-radius on comment content (go-gitea#29128) Make blockquote border size less aggressive (go-gitea#29124) Drop "@" from email sender to avoid spam filters (go-gitea#29109) [skip ci] Updated translations via Crowdin Disallow duplicate storage paths (go-gitea#26484) ...
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Shows more settings for empty repositories (Fixes go-gitea#29060)
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
Shows more settings for empty repositories (Fixes go-gitea#29060) (cherry picked from commit 28db539)
|
Automatically locked because of our CONTRIBUTING guidelines |
lunny
added
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows more settings for empty repositories with setting
EnableCodetrue (Fixes #29060)before:
after:
