Revert "Show View at this point in history for every commit (#29122)"

[wxiaoguang]

Fix #30098

[zokkis]

Why should this be reverted and not fixed?

I think its better to check if its a commit, then use src/commit and if its wiki use wiki/commit
like https://github.com/go-gitea/gitea/blob/db73904e7062d9442ddad577be09965dad2e2826/templates/repo/commits_list.tmpl#L45C8-L55C12

[wxiaoguang]

Why should this be reverted and not fixed?

Quote my comment from #29122 :

Actually I have a question for this change: if there is no FileName, why it should show a link to the commit? The commit link is already shown in the second column. If I understand correctly, View at this point in history is only for viewing a "file", but not a "commit". I think the change 29122 is not right.

At the moment, a complete fix for "wiki" needs more time, and "wiki" doesn't support such "file view at history point". So even if you could check it is a wiki, no link could be used.

To make it easier to backport for 1.22, this is a quick fix IMO

[zokkis]

Why should this be reverted and not fixed?

Quote my comment from #29122 :

Actually I have a question for this change: if there is no FileName, why it should show a link to the commit? The commit link is already shown in the second column. If I understand correctly, View at this point in history is only for viewing a "file", but not a "commit". I think the change 29122 is not right.

At the moment, a complete fix for "wiki" needs more time, and "wiki" doesn't support such "file view at history point". So even if you could check it is a wiki, no link could be used.

To make it easier to backport for 1.22, this is a quick fix IMO

The button does a similar thing as a click on "sha1" column

On the sha1 click you see the commit but with View at this point in history you see the repo at this commit

So the absolute best and also a easy fix is to check for wiki and then dont show the link
So the feature is not reverted and the bug is fixed

[wxiaoguang]

Hmm, sorry, I think I can see the point now. Will propose a new one.

[wxiaoguang]

Sorry for my misundestanding and sorry for bothering, the new PR: -> https://github.com/go-gitea/gitea/pull/30297/files?diff=split&w=1