-
Notifications
You must be signed in to change notification settings - Fork 61.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a couple of inline links to the Reusables and variables section of content-style-guide.md #2732
Comments
@hamirmahal Thanks for opening an issue! Triaging this now so someone can dig in! |
👍🏻 Thanks @hamirmahal! You or anyone else are welcome to open a PR to make this improvement. 🔧 |
Hello @emilyistoofunky, @chiedo, and @janiceilene! I made the suggested changes and opened a pull request for this issue. This is only my second time opening a pull request, so please let me know if there's anything I could do better next time. Thanks so much! -Rami |
Why: Line 279: link 'data directory' to data repository and 'Product names' to product names section for faster access. Issue github#2732 What's being changed: Line 279: Linked 'data directory' to data repository and 'Product names' to product names section.
Thank you @MeetYourCreator! We appreciate you hopping in and opening a pull request for the first time. It looks like you opened the Pull Request on your fork rather than on this repo. Can you give it another shot but this time open the Pull Request here instead (using your repo as a base)? More docs on Pull requests if they're helpful! |
I responded in the PR! |
Hi @chiedo, Let me start by saying THANK YOU THANK YOU THANK YOU for being so patient and helpful. I looked over the pull request documentation again, and opened up a new pull request #2829. I double-checked to make sure that I was trying to merge to the main branch for gitub-docs and that there were Files showing in the Files tab: I really hope I got it right this time. Thank you so much for helping to guide me along :) |
Hi @MeetYourCreator! Thanks so much for taking a look at this issue - it looks like the author of this issue opened a PR (#2751) earlier than you did, so we're going to merge that one. We appreciate you getting set up to contribute to this repo and look forward to working with you on future issues. ⚡ |
Hi @emilyistoofunky! Thanks so much for letting me know. And thanks again @chiedo for the very helpful guidance :) |
Add a couple of inline links for convenience to close #2732
What article on docs.github.com is affected?
This issue actually isn't in relation to an issue with docs.github.com. I'd like to improve the "Reusables and variables" section of
contributing/content-style-guide.md
by adding a couple of inline links for convenience.What part(s) of the article would you like to see updated?
I would like to change the final sentence of the section I just mentioned,
so that "data directory" and "Product names" have links to the appropriate sections for faster access.
Additional information
I think this would make it easier for first-time contributors to this repository to find the information they need. I may have a fix for this.
The text was updated successfully, but these errors were encountered: