Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of inline links for convenience to close #2732 #2751

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Add a couple of inline links for convenience to close #2732 #2751

merged 4 commits into from
Jan 14, 2021

Conversation

hamirmahal
Copy link
Contributor

@hamirmahal hamirmahal commented Jan 10, 2021

Closes #2732.

Why:

I think adding inline links will increase the productivity of people wanting to contribute, especially first-time contributors.

What's being changed:

I changed the last sentence of the "Reusables and variables" section of contributing/content-style-guide.md, which is

For more information, see the data directory in the github/docs repository and the “Product names” section of this document.

to use a couple of relative links to access the appropriate sections, since I think this makes navigation easier and more convenient.

Check off the following:

@hamirmahal hamirmahal requested a review from a team as a code owner January 10, 2021 22:15
@janiceilene janiceilene added the contributing docs Content related to our contributing docs label Jan 11, 2021
@janiceilene
Copy link
Contributor

@hamirmahal Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Member

@emilyistoofunky emilyistoofunky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamirmahal! ✨ We'll get this merged soon.

@janiceilene janiceilene merged commit 037d26c into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@hamirmahal
Copy link
Contributor Author

@emilyistoofunky @janiceilene You're welcome! Thank you for approving and merging.

@hamirmahal hamirmahal deleted the feat/add-inline-links branch January 17, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributing docs Content related to our contributing docs ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a couple of inline links to the Reusables and variables section of content-style-guide.md
3 participants