Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-inline-links-to-contributing/content-style-guide.md_issue #2732 #2828

Conversation

ramizackaryshamir
Copy link

@ramizackaryshamir ramizackaryshamir commented Jan 12, 2021

Why:

Line 279: link 'data directory' to data repository and 'Product names' to product names section for faster access. Issue #2732

What's being changed:

Line 279: Linked 'data directory' to data repository and 'Product names' to product names section.

Screen Shot 2021-01-12 at 1 27 25 PM

Check off the following:

Rami Zackary Shamir added 3 commits January 12, 2021 13:35
Why:
Line 279: link 'data directory' to data repository and 'Product names' to product names section for faster access. Issue github#2732

What's being changed:
Line 279: Linked 'data directory' to data repository and 'Product names' to product names section.
@ramizackaryshamir ramizackaryshamir changed the title Revert 1 meetYourCreator patch issue#2732 MeetYourCreator patch issue #2732 Jan 12, 2021
@ramizackaryshamir ramizackaryshamir changed the title MeetYourCreator patch issue #2732 MeetYourCreator patch-issue #2732 Jan 12, 2021
@ramizackaryshamir ramizackaryshamir changed the title MeetYourCreator patch-issue #2732 add-inline-links-to-content-style.md_issue #2732 Jan 12, 2021
@ramizackaryshamir ramizackaryshamir changed the title add-inline-links-to-content-style.md_issue #2732 add-inline-links-to-contributing/content-style-guide.md_issue #2732 Jan 12, 2021
@chiedo
Copy link
Contributor

chiedo commented Jan 12, 2021

Thanks @MeetYourCreator! We're getting close. Something isn't quite right but no big deal, we can work through it!

I'm not seeing your change in the Files tab here.

Can you copy these changes that you made in your old PR into this one?

Maybe you accidentally reverted the work in this commit.

@ramizackaryshamir
Copy link
Author

ramizackaryshamir commented Jan 12, 2021

Hi @chiedo, Let me start by saying THANK YOU THANK YOU THANK YOU for being so patient and helpful. I looked over the pull request documentation again, and opened up a new pull request #2829. I double-checked to make sure that I was trying to merge to the main branch for gitub-docs and that there were Files showing in the Files tab:

Screen Shot 2021-01-12 at 2 54 58 PM

I really hope I got it right this time. Thank you so much for helping to guide me along :)

@emilyistoofunky
Copy link
Member

Closing this due to an earlier PR (see #2732 (comment)) - thanks again for taking a look at this issue and taking the time to get set up to contribute to this repo @MeetYourCreator. 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants