Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If varia is open before opening Chrome, the ENTIRE download history is sent to varia #110

Closed
Martmists-GH opened this issue May 26, 2024 · 10 comments
Closed

If varia is open before opening Chrome, the ENTIRE download history is sent to varia #110

Martmists-GH opened this issue May 26, 2024 · 10 comments

Comments

@Martmists-GH
Copy link

No description provided.

@N0tACyb0rg
Copy link
Contributor

Could you attach a video of this behavior?

@Martmists-GH
Copy link
Author

Here's a video. This small clip created 7000 files with combined size of 70GB. Needless to say that's not just file downloads I paused before a reboot.

varia.mp4

@N0tACyb0rg
Copy link
Contributor

I was able to reproduce this on a blank user profile in Chrome, I will start looking into a fix.

@N0tACyb0rg N0tACyb0rg mentioned this issue May 29, 2024
Merged
@N0tACyb0rg
Copy link
Contributor

I just dropped a PR that fixes this, you can check out my branch if you need the fix ASAP.

@Martmists-GH
Copy link
Author

@N0tACyb0rg How do I use your PR? I tried editing the PKGBUILD but I only get errors:

$ yay -S varia --editmenu
AUR Explicit (1): varia-2024.5.7-1
:: PKGBUILD up to date, skipping download: varia
  1 varia                                    (Installed) (Build Files Exist)
==> Packages to cleanBuild?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 
  1 varia                                    (Installed) (Build Files Exist)
==> Diffs to show?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 
  1 varia                                    (Installed) (Build Files Exist)
==> PKGBUILDs to edit?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> 1
<-- here I edit the PKGBUILD to use your repo's zip release of the browserfix branch, and skip the sha check -->
:: Proceed with install? [Y/n] 
==> Making package: varia 2024.5.7-1 (Tue 04 Jun 2024 09:09:00 AM CEST)
==> Retrieving sources...
  -> Found varia-2024.5.7.zip
==> WARNING: Skipping verification of source file PGP signatures.
==> Validating source files with sha256sums...
    varia-2024.5.7.zip ... Skipped
:: (1/1) Parsing SRCINFO: varia
==> Making package: varia 2024.5.7-1 (Tue 04 Jun 2024 09:09:01 AM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found varia-2024.5.7.zip
==> Validating source files with sha256sums...
    varia-2024.5.7.zip ... Skipped
==> Removing existing $srcdir/ directory...
==> Extracting sources...
  -> Extracting varia-2024.5.7.zip with bsdtar
==> Sources are ready.
==> Making package: varia 2024.5.7-1 (Tue 04 Jun 2024 09:09:01 AM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Removing existing $pkgdir/ directory...
==> Starting build()...
+ exec meson setup --prefix /usr --libexecdir lib --sbindir bin --buildtype plain --auto-features enabled --wrap-mode nodownload -D b_pie=true -D python.bytecompile=1 varia-2024.5.7 build

ERROR: Neither source directory 'varia-2024.5.7' nor build directory 'build' exist.
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: varia-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
varia - exit status 4

@N0tACyb0rg
Copy link
Contributor

The extension isn't installed with the AUR package, here's the CRX file with my fixes. Google Drive

@Martmists-GH
Copy link
Author

Do you have a zip file instead? Chrome seems to automatically delete the CRX file.

@N0tACyb0rg
Copy link
Contributor

I'll get a zip when I can, but you should just be able to tell Chrome to download it anyways.

@Martmists-GH
Copy link
Author

When I tell chrome the file is safe to keep, the file is deleted anyway.

@N0tACyb0rg
Copy link
Contributor

Sorry about that, here's a zip. Google Drive

giantpinkrobots added a commit that referenced this issue Sep 23, 2024
@giantpinkrobots
Squashed commit of the following:
edf5972 
commit 8232d88
Merge: dac8859 51a5b51
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 13:08:51 2024 +0300

    Merge pull request #120 from Vovkiv/main

    Update Ukrainian translation

commit 51a5b51
Author: Vovkiv <54743395+Vovkiv@users.noreply.github.com>
Date:   Sun Sep 22 11:35:00 2024 +0000

    Update Ukrainian translation

    With new strings

commit 232dc9f
Author: volkov <volkovissocool@gmail.com>
Date:   Sat Aug 10 01:15:43 2024 +0300

    Update Ukrainian translation.

commit dac8859
Merge: 4c0f72e 71dac18
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Sun Jul 28 22:15:05 2024 +0300

    Merge pull request #111 from N0tACyb0rg/browserfix

    Check if Downloads are Older than the Browser Session

commit 71dac18
Author: N0tACyb0rg <n0tacyb0rg@proton.me>
Date:   Wed May 29 12:00:46 2024 -0700

    Fix #110.
giantpinkrobots added a commit that referenced this issue Nov 7, 2024
@giantpinkrobots
Squashed commit of the following:
015e8aa 
commit 26cbb23
Merge: 7938cdc f9aab9a
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Thu Nov 7 19:11:27 2024 +0300

    Merge pull request #122 from Nekothegamer/next

    Update Italian translation

commit 7938cdc
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Thu Nov 7 19:09:56 2024 +0300

    Preparation for new version: v2024.11.7

    - All necessary metadata updated with the new version string and changelogs.
    - Last minute bug fix regarding the Update function on Windows. (aria2 couldn't download to working directory)
    - Screenshots updated again to reflect the latest bug fixes.
    - README layout adjustments.
    - All links in the Homepage set to download the latest binaries.
    - python3-aria2p Python library updated for Flatpak.

commit ea8b2ea
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Tue Nov 5 18:34:38 2024 +0300

    UI adjustments and bug fixes

    - The file name in a download process card now cuts off dynamically instead of after a set amount of characters.
    - Enabling scheduling no longer overwrites the icon in the sidebar Download button.
    - Switched the simultaneous download amount setting from an Adw.ComboRow to an Adw.SpinRow.
    - Size of Scheduler window is redefined and it no longer does the weird resizing once a timespan is added.
    - Margin adjustments for the sake of symmetry, some design alterations to the download process cards.

commit b6fd218
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Wed Oct 30 03:02:12 2024 +0300

    Bug fixes & adjustments

    - Bug fix regarding pause buttons in download lists (got rid of overly complicated system)
    - Shutdown after completion now works on Windows
    - Small UI adjustments

commit 6c2f10b
Merge: 87274a6 e78bf1e
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Sat Oct 26 22:32:30 2024 +0300

    Merge pull request #129 from Alexmelman88/next

    Update Russian translation

commit e78bf1e
Author: Alexmelman88 <99257010+Alexmelman88@users.noreply.github.com>
Date:   Sat Oct 26 17:52:43 2024 +0300

    Update ru.po

commit 87274a6
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Sat Oct 26 17:34:14 2024 +0300

    Windows version improvements & more

    - New updater function for Windows, allowing for automatic updates for the installer directly through Github.
    - Windows version now supports localization and all icons are properly displayed.
    - New build script for Windows that handles all dependencies (except for aria2), compiling localizations and building with PyInstaller.
    - Edits to README to document the new build instructions for Windows.
    - Adherence to the newest GTK 4 standard deprecating widget.show() and hide().
    - Landing page improvements with better css and fixes.
    - Bug fixes regarding threading with GTK and reloading unfinished downloads upon startup.
    - Better handling of total download speed that actually makes sense.
    - Removal of unnecessary imports from files.
    - Up to date screenshots.

commit baf332e
Author: Alexmelman88 <99257010+Alexmelman88@users.noreply.github.com>
Date:   Thu Oct 10 18:46:46 2024 +0300

    Update Russian translation

commit d63739d
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Fri Sep 27 23:28:22 2024 +0300

    Add torrent file button & Adjustments 27 Sept 24

    - Sidebar layout adjusted and redesigned, new torrent button added. Download button is no longer clickable when there is no URL set.
    - ETA string now shows infinity symbol when download speed is zero.
    - Search enabled in the Preferences screen.
    - Aria2 now uses "--file-allocation=falloc" when the OS supports it and allows for file overwrites.

commit 816832c
Merge: edf5972 ed3e40d
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 18:10:10 2024 +0300

    Merge pull request #105 from haggen88/update-spanish

    update spanish translation

commit ed3e40d
Author: haggen88 <68134588+haggen88@users.noreply.github.com>
Date:   Mon Sep 23 11:38:15 2024 -0300

    update spanish

commit aab31a8
Author: haggen88 <68134588+haggen88@users.noreply.github.com>
Date:   Mon Sep 23 11:36:56 2024 -0300

    Update es.po

commit edf5972
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 14:21:56 2024 +0300

    Squashed commit of the following:

    commit 8232d88
    Merge: dac8859 51a5b51
    Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
    Date:   Mon Sep 23 13:08:51 2024 +0300

        Merge pull request #120 from Vovkiv/main

        Update Ukrainian translation

    commit 51a5b51
    Author: Vovkiv <54743395+Vovkiv@users.noreply.github.com>
    Date:   Sun Sep 22 11:35:00 2024 +0000

        Update Ukrainian translation

        With new strings

    commit 232dc9f
    Author: volkov <volkovissocool@gmail.com>
    Date:   Sat Aug 10 01:15:43 2024 +0300

        Update Ukrainian translation.

    commit dac8859
    Merge: 4c0f72e 71dac18
    Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
    Date:   Sun Jul 28 22:15:05 2024 +0300

        Merge pull request #111 from N0tACyb0rg/browserfix

        Check if Downloads are Older than the Browser Session

    commit 71dac18
    Author: N0tACyb0rg <n0tacyb0rg@proton.me>
    Date:   Wed May 29 12:00:46 2024 -0700

        Fix #110.

commit 344998b
Merge: ba7aac1 cd5c429
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 14:11:52 2024 +0300

    Merge pull request #119 from Nokse22/next

    Added mimetype and icon for .aria2 file

commit cd5c429
Merge: 1f0b3f4 1a14946
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 14:09:09 2024 +0300

    Merge branch 'next' of https://github.com/nokse22/varia into pr/Nokse22/119-1

commit 1f0b3f4
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 14:08:28 2024 +0300

    File extension change

    Varia now uses the ".varia" file extension instead of ".varia.json". The mimeinfo now registers ".varia" files as "Varia Download Progress" and ".aria2" files as "Aria2 Download Progress".

commit 5c80416
Author: Nokse22 <44558032+Nokse22@users.noreply.github.com>
Date:   Tue Aug 6 15:08:03 2024 +0200

    Added mimetype and icon for .aria2 file

commit ba7aac1
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 13:38:14 2024 +0300

    Fix Russian language

    Remove a missed duplicate string that was preventing Varia from building

commit 21be504
Merge: fd2f5b6 2900eac
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 13:09:42 2024 +0300

    Merge pull request #106 from Alexmelman88/next

    Update Russian translation

commit fd2f5b6
Merge: 8e17945 ba976df
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 13:09:21 2024 +0300

    Merge pull request #115 from twlvnn/next

    Added Bulgarian translation

commit 8e17945
Merge: 5f09fda 8bd9f04
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Mon Sep 23 13:08:00 2024 +0300

    Merge pull request #102 from gnuey56/next

    Update Japanese translation

commit 8bd9f04
Author: Gnuey56 <gnuey56@proton.me>
Date:   Mon Sep 23 11:56:46 2024 +0900

    Update Japanese translation

commit f1f1105
Merge: eb7f85b 5f09fda
Author: Gnuey56 <138874824+gnuey56@users.noreply.github.com>
Date:   Mon Sep 23 11:26:06 2024 +0900

    Merge branch 'giantpinkrobots:next' into next

commit 2900eac
Author: Alexmelman88 <99257010+Alexmelman88@users.noreply.github.com>
Date:   Sun Sep 22 13:47:57 2024 +0300

    Update ru.po

commit 23fdcb5
Merge: 1a11443 5f09fda
Author: Alexmelman88 <99257010+Alexmelman88@users.noreply.github.com>
Date:   Sun Sep 22 13:38:18 2024 +0300

    Merge branch 'giantpinkrobots:next' into next

commit ba976df
Author: twlvnn <kraft_werk@tutanota.com>
Date:   Sun Sep 22 12:30:32 2024 +0200

    Updated Bulgarian translation

commit c82a891
Merge: 1989d1e 5f09fda
Author: twlvnn <kraft_werk@tutanota.com>
Date:   Sun Sep 22 12:24:35 2024 +0200

    Merge branch 'giantpinkrobots:next' into next

commit 5f09fda
Merge: 751c858 cdb4607
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Sun Sep 22 13:11:03 2024 +0300

    Merge pull request #124 from lumingzh/translation

    Add Chinese translation

commit cdb4607
Author: lumingzh <lumingzh@qq.com>
Date:   Sun Sep 22 17:59:21 2024 +0800

    update Chinese translation

commit 751c858
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Fri Sep 20 20:08:42 2024 +0300

    Adjustments - 20 Sept 24

    - Switch to some newer Libadwaita widgets
    - "Exiting Varia" dialog is now shown on top of the main window
    - Remote aria2 setting re-added
    - Missing translations added
    - Homepage screenshots fixed

commit ab42cfa
Merge: c7d244e 34e2dd7
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Tue Sep 17 00:23:53 2024 +0300

    Merge pull request #127 from N0tACyb0rg/timelabel

    Add Time Remaining for Downloads

commit 34e2dd7
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Tue Sep 17 00:22:27 2024 +0300

    Localization support

    "remaining" is now a translatable string.

commit 088195c
Merge: bee59dc c7d244e
Author: haggen88 <68134588+haggen88@users.noreply.github.com>
Date:   Fri Sep 13 11:29:45 2024 -0300

    Merge branch 'giantpinkrobots:next' into update-spanish

commit b578573
Author: N0tACyb0rg <n0tacyb0rg@proton.me>
Date:   Wed Sep 11 10:20:21 2024 -0700

    Add time remaining for downloads.

commit bd84d04
Author: lumingzh <lumingzh@qq.com>
Date:   Tue Sep 3 19:51:42 2024 +0800

    Add Chinese translation

commit 4548f22
Author: lumingzh <lumingzh@qq.com>
Date:   Tue Sep 3 19:50:01 2024 +0800

    Update LINGUAS

commit f9aab9a
Author: Nekothegamer <112352776+Nekothegamer@users.noreply.github.com>
Date:   Sat Aug 24 18:04:56 2024 +0200

    Add translation file

commit 1a14946
Author: Nokse22 <44558032+Nokse22@users.noreply.github.com>
Date:   Tue Aug 6 15:08:03 2024 +0200

    Added mimetype and icon for .aria2 file

commit c7d244e
Merge: 4c0f72e 90310b5
Author: Giant Pink Robots! <giantpinkrobots@protonmail.com>
Date:   Sun Jul 28 22:13:26 2024 +0300

    Merge pull request #108 from N0tACyb0rg/dirfix

    Fix GLib.USER_DIRECTORY_HOME Error

commit 1989d1e
Author: twlvnn <kraft_werk@tutanota.com>
Date:   Sat Jul 6 13:08:01 2024 +0200

    Added Bulgarian translation

commit 90310b5
Author: N0tACyb0rg <caleb.xavier.marshall@gmail.com>
Date:   Mon May 13 18:39:10 2024 -0700

    Add fix for #94 and #107.

commit 1a11443
Author: Alexmelman88 <99257010+Alexmelman88@users.noreply.github.com>
Date:   Sun May 12 01:17:23 2024 +0300

    Update ru.po

commit bee59dc
Author: haggen88 <68134588+haggen88@users.noreply.github.com>
Date:   Fri May 10 15:42:13 2024 -0400

    update es.po

commit eb7f85b
Author: Gnuey56 <gnuey56@proton.me>
Date:   Fri May 10 19:54:19 2024 +0900

    Update Japanese translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Martmists-GH @N0tACyb0rg