Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit unimplemented errors for several @diagnostic(…) attribute parse sites #6533

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Emit unimplemented errors for several @diagnostic(…) attribute parse sites #6533

merged 6 commits into from
Nov 13, 2024

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Nov 12, 2024 •
edited
Loading

Connections

Description

-

Testing

  • I've tested this manually, and plan on following up with actual test coverage in a separate PR.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler requested a review from a team November 12, 2024 22:56
@ErichDonGubler ErichDonGubler self-assigned this Nov 12, 2024
@ErichDonGubler ErichDonGubler added naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language labels Nov 12, 2024
@ErichDonGubler ErichDonGubler changed the title Add several unimplemented diagnostics for @diagnostic(…) attributes Emit unimplemented errors for several @diagnostic(…) attribute parse sites Nov 12, 2024
@ErichDonGubler ErichDonGubler mentioned this pull request Nov 12, 2024
Merged
13 tasks
teoxoy
teoxoy requested changes Nov 13, 2024
View reviewed changes
naga/src/front/wgsl/parse/mod.rs Show resolved Hide resolved
naga/src/front/wgsl/parse/mod.rs Show resolved Hide resolved
naga/src/front/wgsl/error.rs Outdated Show resolved Hide resolved
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Nov 13, 2024 •
edited
Loading

Just added this PR to the existing Major changes entry for diagnostic filters in the CHANGELOG with 4b99d66.

@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) November 13, 2024 12:24
@ErichDonGubler
Copy link
Member Author

@teoxoy: Did you review the first commits in this PR that are also in #6503? If so, I can close that PR, noting that you already reviewed those commits.

@teoxoy
Copy link
Member

teoxoy commented Nov 13, 2024

Yeah, it looks consistent with Jim's request in #6485.

@ErichDonGubler ErichDonGubler mentioned this pull request Nov 13, 2024
Closed
7 tasks
@ErichDonGubler ErichDonGubler merged commit 693eaaf into gfx-rs:trunk Nov 13, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the unimpl-diag-filt-diags branch November 13, 2024 13:59
@ErichDonGubler ErichDonGubler mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @teoxoy