-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wgsl-in): parse diagnostic(…)
attributes on fn
s
#6353
Merged
ErichDonGubler
merged 2 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:erichdongubler/push-xlypklnukzlu
Nov 15, 2024
Merged
feat(wgsl-in): parse diagnostic(…)
attributes on fn
s
#6353
ErichDonGubler
merged 2 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:erichdongubler/push-xlypklnukzlu
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
bf4eab8
to
a954d89
Compare
3039803
to
6479c1d
Compare
9b6f777
to
319229a
Compare
05f8ba6
to
8a3e747
Compare
b77694d
to
45fb2e5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
diagnostic(…)
attributes on fn
sdiagnostic(…)
attributes on fn
s
Populated the OP with test results. |
212f4f3
to
7d8fd78
Compare
7 tasks
7d8fd78
to
8bab515
Compare
8bab515
to
544e70c
Compare
teoxoy
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: naga front-end
area: naga middle-end
Intermediate representation
area: naga processing
Passes over IR in the middle
lang: WGSL
WebGPU Shading Language
naga
Shader Translator
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
@diagnostic(…)
attribute parse sites #6533.diagnostic(…)
) #5320.Description
Building on #6148 and #6533, we use all the plumbing we made for tracking diagnostic rules, and add a (successful) parse path for
@diagnostic(…) fn function() { … }
. This and #6148's parse paths are what I've observed to be the next most common places for users to apply diagnostic filtering, by a wide margin. I expect we willTesting
webgpu:shader,validation,parse,diagnostic:valid_locations:*
…:type="attribute";location="function"
webgpu:shader,validation,parse,diagnostic:duplicate_attribute_same_location:*
…:loc="function";same_rule=true
: ✅…:loc="function";same_rule=false
: ❌ → ✅Only tests statement-position attributes. 🙁webgpu:shader,validation,parse,diagnostic:conflicting_attribute_different_location:*
At least one case inOnly tests statement-position attributes. 🙁webgpu:shader,validation,parse,diagnostic:diagnostic_scoping:*
, specific case TBD.Port a meaningful subset of the above to our own Naga test suite, to prevent the most impactful regressions.Punted for later.Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.