Isolate WGSL-specific concepts governing diagnostic filters #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
naga
|
Summoning @jimblandy as a reviewer, since he filed the issue motivating this PR (#6485). |
ErichDonGubler
force-pushed
the
distinguish-diag-filters-and-wgsl
branch
4 times, most recently
from
6e8c95d to
38a0e55
Compare
ErichDonGubler
force-pushed
the
distinguish-diag-filters-and-wgsl
branch
from
38a0e55 to
a04b1cb
Compare
|
This should be ready for review now, @jimblandy! |
7 tasks
|
Reviewed in #6533. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Resolves #6485.
Description
-
Testing
If this compiles, I consider it tested. 🙂
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toNo user-facing changes, so none needed.CHANGELOG.md. See simple instructions inside file.