Renderpass take resource ownership #5884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
renderpass-take-resource-ownership
branch
from
a7bec42
to
c097717
Compare
Wumpf
force-pushed
the
renderpass-take-resource-ownership
branch
2 times, most recently
from
d10100d
to
bdc6328
Compare
…ership of resources passed on pass creation
Wumpf
force-pushed
the
renderpass-take-resource-ownership
branch
from
6347d28
to
ebbbdf2
Compare
Wumpf
force-pushed
the
renderpass-take-resource-ownership
branch
from
ebbbdf2
to
a6bcbf1
Compare
…coder locking errors with render passes
Wumpf
force-pushed
the
renderpass-take-resource-ownership
branch
from
a6bcbf1
to
a463cdd
Compare
nical
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
RenderPassmake it difficult to use. #1453ComputePassto its parent command encoder #5620wgpu::ComputePass::forget_lifetime#5768Description
Just like ComputePass before, we now take ownership of all ingoing resources to a RenderPass right away. We also take ownership of the parent encoder, making it possible to convert
RenderPass<'a>->RenderPass<'static>(as opt-in)Testing
New ownership tests added (very similar to what we added for compute pass previously)
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.