Remove more internal uses of IDs #3 #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in_pipeline_statistics_query`
all relevant inner errors already print the label of the buffers
and make sure that we use `ResourceErrorIdent` in all relevant inner errors
and make sure that we use `ResourceErrorIdent` in all relevant inner errors
and make sure that we use `ResourceErrorIdent` in all relevant inner errors
|
Hmm even more conflicts with #5884, still haven't recovered from the last. Well, I guess I'll have to suck it up; that pr is still incomplete as there's a bunch of tests missing. Edit: while I don't have time for a full review right now, skimming this some more it doesn't look all that bad since the core areas touched are different - good the the command arcanization thing went in before! I love the work you're doing here, more than willing to redo my draft on top! |
|
Sorry for the conflicts, I can help rebase, just let me know. |
nical
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I extracted the code from passes was because
PassErrorScopeisCopyand I wanted to replace all the resources referenced by ids in its variants withResourceErrorIdents which is notCopy. After going through all the work to do that, I realized I could remove the ids from all variants anyway because the inner error types already containedResourceErrorIdent's where relevant; or if they didn't I added them. I think we should still land the code extractions since we can now deduplicate some of the code; it also removes the need to keep calling.map_pass_err()everywhere.Part of #5121.
PR doesn't need to be squashed, each commit builds by itself.