Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more internal uses of IDs #3 #5883

Merged
merged 47 commits into from
Jun 27, 2024
Merged

Remove more internal uses of IDs #3 #5883

merged 47 commits into from
Jun 27, 2024

Commits on Jun 25, 2024

  1. use .error_ident() for api_log!s in render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bc6020f View commit details
    Browse the repository at this point in the history

  2. inline pipeline.as_info().id()

    @teoxoy
    teoxoy committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e0d2bef View commit details
    Browse the repository at this point in the history

  3. simplify IndexState

    @teoxoy
    teoxoy committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9931790 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. extract render bundle command processing into their own functions

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6cffe1d View commit details
    Browse the repository at this point in the history

  2. add more fields to State and cleanup fn params

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ac90e26 View commit details
    Browse the repository at this point in the history

  3. move comment that was preventing fmt from running

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2da8218 View commit details
    Browse the repository at this point in the history

  4. remove multi_draw_indirect2

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    67d77df View commit details
    Browse the repository at this point in the history

  5. put all state in State

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5bbf63f View commit details
    Browse the repository at this point in the history

  6. remove CommandBuffer.limits

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3309a07 View commit details
    Browse the repository at this point in the history

  7. extract set_bind_group from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f8656d3 View commit details
    Browse the repository at this point in the history

  8. extract set_pipeline from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    45fce5b View commit details
    Browse the repository at this point in the history

  9. extract set_push_constant from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    90ef6b9 View commit details
    Browse the repository at this point in the history

  10. extract dispatch from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a8993cf View commit details
    Browse the repository at this point in the history

  11. extract dispatch_indirect from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a349fc8 View commit details
    Browse the repository at this point in the history

  12. extract push_debug_group from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    06b3d44 View commit details
    Browse the repository at this point in the history

  13. extract pop_debug_group from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9ad79f8 View commit details
    Browse the repository at this point in the history

  14. extract insert_debug_marker from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4a932fc View commit details
    Browse the repository at this point in the history

  15. extract write_timestamp from compute_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2564330 View commit details
    Browse the repository at this point in the history

  16. move same device check and tracker insertion inside `validate_and_beg… 

    …in_pipeline_statistics_query`
    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    51c4ad3 View commit details
    Browse the repository at this point in the history

  17. move the raw encoder in State

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3b52c1d View commit details
    Browse the repository at this point in the history

  18. put all state in State

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f6b362f View commit details
    Browse the repository at this point in the history

  19. extract set_bind_group from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7e140e1 View commit details
    Browse the repository at this point in the history

  20. extract set_pipeline from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    84a44ae View commit details
    Browse the repository at this point in the history

  21. extract set_index_buffer from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3fb6bd4 View commit details
    Browse the repository at this point in the history

  22. extract set_vertex_buffer from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c120a0f View commit details
    Browse the repository at this point in the history

  23. extract set_blend_constant from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    99276f5 View commit details
    Browse the repository at this point in the history

  24. extract set_stencil_reference from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    51512ae View commit details
    Browse the repository at this point in the history

  25. extract set_viewport from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c0e93fd View commit details
    Browse the repository at this point in the history

  26. extract set_push_constant from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3e05cec View commit details
    Browse the repository at this point in the history

  27. extract set_scissor from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3420c45 View commit details
    Browse the repository at this point in the history

  28. extract draw from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8081125 View commit details
    Browse the repository at this point in the history

  29. extract draw_indexed from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    66790fe View commit details
    Browse the repository at this point in the history

  30. extract multi_draw_indirect from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    97918b5 View commit details
    Browse the repository at this point in the history

  31. extract multi_draw_indirect_count from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7de1447 View commit details
    Browse the repository at this point in the history

  32. extract push_debug_group from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6bd3fc1 View commit details
    Browse the repository at this point in the history

  33. extract pop_debug_group from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8ebb72f View commit details
    Browse the repository at this point in the history

  34. extract insert_debug_marker from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    df45624 View commit details
    Browse the repository at this point in the history

  35. extract write_timestamp from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e28d934 View commit details
    Browse the repository at this point in the history

  36. resolve occlusion query set prior to render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bcfb22b View commit details
    Browse the repository at this point in the history

  37. extract execute_bundle from render_pass_end_impl

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2f7a248 View commit details
    Browse the repository at this point in the history

  38. move pipeline ident to DispatchError::IncompatibleBindGroup

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    875a16f View commit details
    Browse the repository at this point in the history

  39. move pipeline ident to appropriate errors

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9f1cba1 View commit details
    Browse the repository at this point in the history

  40. remove buffer id from set index/vertex buffer scopes 

    all relevant inner errors already print the label of the buffers
    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    65eb552 View commit details
    Browse the repository at this point in the history

  41. remove compute pipeline id from set compute pipeline scope 

    and make sure that we use `ResourceErrorIdent` in all relevant inner errors
    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8232b8b View commit details
    Browse the repository at this point in the history

  42. remove render pipeline id from set render pipeline scope 

    and make sure that we use `ResourceErrorIdent` in all relevant inner errors
    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9dba43e View commit details
    Browse the repository at this point in the history

  43. use .validate_dynamic_bindings() in render bundle's set_bind_group

    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    2c3b82b View commit details
    Browse the repository at this point in the history

  44. remove bind group id from set bind group scope 

    and make sure that we use `ResourceErrorIdent` in all relevant inner errors
    @teoxoy
    teoxoy committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5c80956 View commit details
    Browse the repository at this point in the history