Skip the cube compatibility on a downlevel flag #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jun 1, 2021
There was a problem hiding this comment.
We should keep the aniso downlevel flag. I know that the webgpu standard does not say that ANISO has to do anything, but people should still know when it's going to be ignored. If you want to change the "is compliant" to not include aniso that's fine, but I generally dislike misrepresenting the device's capabilities to the client.
|
Ok, the compatibility mask was wrong then, it took aniso into it. I'll add the flag back, but outside of the compat mask. |
|
The review note is addressed, let's proceed. |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jun 1, 2021
921: Update wgpu to eadaa1b r=kvark a=kvark Picks up gfx-rs/wgpu#1419, gfx-rs/wgpu#1417, and gfx-rs/wgpu#1403 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
921: Update wgpu to eadaa1b r=kvark a=kvark Picks up gfx-rs#1419, gfx-rs#1417, and gfx-rs#1403 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1418
Description
Adds a downlevel flag for cube arrays, checks for it.
Testing
Untested, but should work.