Split the tracker into stateful/stateless to reduce the overhead #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jun 1, 2021
921: Update wgpu to eadaa1b r=kvark a=kvark Picks up gfx-rs/wgpu#1419, gfx-rs/wgpu#1417, and gfx-rs/wgpu#1403 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
921: Update wgpu to eadaa1b r=kvark a=kvark Picks up gfx-rs#1419, gfx-rs#1417, and gfx-rs#1403 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jun 23, 2021
1547: Don't merge stateless trackers from bind groups r=cwfitzgerald a=kvark **Connections** Hinted by @pythonesque on the matrix Follow-up to #1417 **Description** This is an optimization only. When a bind group is used, we need to ensure two things: 1. stateful usages are merged in (buffers and textures) 2. other resources are help alive by the command buffer We used to merge all of the states into the local trackers. However, the local tracker already keeps a strong reference to the whole bind group, so the resources in it are not going away. Therefore, we can skip having them separately in the local trackers. **Testing** Untested. Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Implements #1413 (comment)
Reduces the overhead for resource tracking in the Animometer benchmark by up to 50%.
Description
We used to use the full tracker set on the usage scopes associated with compute/render passes. A resource tracker has 2 responsibilities: ensuring the resource is held alive, and validating and recording the state transitions. This PR exploits the fact that the latter responsibility is only applicable for buffers and textures. So doing all the lifetime tracking for a pass is a waste: we can instead just attach the lifetimes to the parent command buffer, straight.
In the Animometer benchmark, there is one large buffer, and thousands of bind groups pointing to different offsets into it. The old code would fill up the pass tracker with those bind groups, and then merge it into the command buffer tracker. The new code would just fill up the command buffer tracker instead. Since there is only one buffer, the pass tracking becomes much lighter.
Testing
Untested. It would be nice to have some benchmarks here, possibly after #1397 ?