Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Add pylint/PEP8 checks to GitHub Actions to validate the python shell #137

Closed
p013570 opened this issue Jun 28, 2017 · 3 comments · Fixed by #1028
Closed

Add pylint/PEP8 checks to GitHub Actions to validate the python shell #137

p013570 opened this issue Jun 28, 2017 · 3 comments · Fixed by #1028
Assignees
@lb324567
Labels
enhancement good first issue python-shell testing
Milestone
v2.0.0-alpha-0.4

Comments

@p013570
Copy link
Member

p013570 commented Jun 28, 2017

Travis should run some code analysis checks to determine whether the Python shell is ready for release, e.g. pylint/PEP8.
@p013570 p013570 mentioned this issue Jun 28, 2017
Closed
@p013570 p013570 added this to the Backlog milestone Jan 4, 2018
@p013570 p013570 added the p:low label Jan 4, 2018
@n3101 n3101 modified the milestones: Backlog, v2_backlog Aug 25, 2021
@t92549 t92549 changed the title Add pylint/PEP8 checks to travis ci to validate the python shell Add pylint/PEP8 checks to GitHub Actions to validate the python shell Aug 25, 2021
@t92549
Copy link
Contributor

t92549 commented Aug 25, 2021

Some linting on the Python shell would be nice to ensure code quality

@n3101 n3101 removed the p:low label Feb 15, 2022
@t92549 t92549 mentioned this issue Jul 28, 2022
Closed
@t92549
Copy link
Contributor

t92549 commented Jul 28, 2022

Currently there are lots of inconsistent uses of " and ' for Strings, as well as lines that are very long. A PUP8 linter would flag these.

@t92549 t92549 mentioned this issue Aug 16, 2022
Merged
@lb324567 lb324567 self-assigned this Oct 3, 2022
@lb324567 lb324567 linked a pull request Oct 6, 2022 that will close this issue
gh-137: autopep8 action #1028
Merged
@lb324567 lb324567 mentioned this issue Oct 6, 2022
Closed
@t92549 t92549 modified the milestones: v2_backlog, v2.0.0-alpha-0.4 Oct 11, 2022
@lb324567 lb324567 mentioned this issue Oct 11, 2022
Closed
t92549 added a commit that referenced this issue Oct 13, 2022
@lb324567 @github-actions @t92549
gh-137: autopep8 action (#1028)
5e78c09 
* autopep8 action

* max line length set for atuopep8 job

* Making changes to shorten the command

* Changed generator to create pep-8 code

* Correction to newlines

* Updated README to include link to coding style guidance in documentation

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: lb324567 <lb324567@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
@t92549
Copy link
Contributor

t92549 commented Oct 13, 2022

Fixed by #1028

@t92549 t92549 closed this as completed Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lb324567 lb324567

Labels
enhancement good first issue python-shell testing
Projects
None yet
Milestone
v2.0.0-alpha-0.4
Development

Successfully merging a pull request may close this issue.

137-pep8-checks-to-github-actions gchq/gaffer-tools
gh-137: autopep8 action gchq/gaffer-tools
4 participants
@p013570 @n3101 @t92549 @lb324567