You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
#137 added checks to ensure the Python code conformed to best practices. However, one of the changes that should be made is to move all module level imports to the top of the file. If this is done as the code stands now, it causes circular import issues within the testing.
Part of this may be to do with the generated Fishbowl code, so this might not be something we can easily fix but it should be looked into as we should aim to have all module imports at the top of the file to adhere to best practice.
if this can be fixed, the autopep8 action should also be changed to stop the checks from skipping the E402 rule.
The text was updated successfully, but these errors were encountered:
#137 added checks to ensure the Python code conformed to best practices. However, one of the changes that should be made is to move all module level imports to the top of the file. If this is done as the code stands now, it causes circular import issues within the testing.
Part of this may be to do with the generated Fishbowl code, so this might not be something we can easily fix but it should be looked into as we should aim to have all module imports at the top of the file to adhere to best practice.
if this can be fixed, the autopep8 action should also be changed to stop the checks from skipping the E402 rule.
The text was updated successfully, but these errors were encountered: