Gh 981: integrate fishbowl into gafferpy #1015
Conversation
This reverts commit 3e8c48c.
Codecov Report
@@ Coverage Diff @@
## v2-alpha #1015 +/- ##
===========================================
Coverage ? 45.15%
Complexity ? 101
===========================================
Files ? 25
Lines ? 897
Branches ? 73
===========================================
Hits ? 405
Misses ? 462
Partials ? 30 Continue to review full report at Codecov.
|
|
|
||
| return operation | ||
| class GetElementsWithinSet(GetElementsWithinSet): |
There was a problem hiding this comment.
The GitHub diff makes these difficult to read, but at the bottom of this file here, when you see a Class overriding itself, it is because some extra helper functionality has been manually added to the generated class to retain backwards compatibility.
In this example, we are wrapping any non-list input into a list, then wrapping plain vertices in EntitySeeds.
Perhaps some patterns (like an input of seeds) could be added directly to the generating code in fishbowl to eliminate the need for as many manual additions. As well as cleaning this class up, it would mean when users generate their own versions of gafferpy, they get to keep these extensions without needing to extend directly from this file.
| @@ -5475,10 +5474,6 @@ def test_get_walks_correct_op(self): | |||
| self.assertEqual(g.GetWalks( | |||
| operations=[g.GetElements()]), expected_output_json) | |||
|
|
|||
| def test_get_walks_incorrect_op(self): | |||
There was a problem hiding this comment.
The incorrect get_walks tests have been removed as the error will now come directly from the Gaffer api (500) rather than throwing first in Python.
Related Issue