fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored #9720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (simple) PR fixes a bug I was noticing in gatsbyjs#9629, specifically that __tests__/*.js files _were_ being included in the bundle. This is because the isTestFile function in gatsby-plugin-page-creator is passed the file name, not the file name _with_ the folder (__tests__ in this case). I added a second check to check the dir, but could also just implement this check with the raw file path, as well
DSchau
commented
Nov 5, 2018
| @@ -10,28 +10,26 @@ describe(`JavaScript page creator`, () => { | |||
| { path: `somedir/dir2/test1.js` }, | |||
| ] | |||
|
|
|||
| expect(validFiles.filter(file => validatePath(file.path)).length).toEqual(validFiles.length) | |||
| expect(validFiles.filter(file => validatePath(file.path))).toEqual( | |||
There was a problem hiding this comment.
Also removed all the .length checks. It's a lot safer to validate the actual array shape rather than the length of the array, even though there weren't any changes required here!
e.g. if one of the validFiles was failing and one of the invalid files was passing, we could still get the expected length
pieh
changed the title
This reverts commit dbc2ffe.
|
e2e tests failing because of new dependency not being handled, so merging this |
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Nov 6, 2018
* 'master' of github.com:gatsbyjs/gatsby: (63 commits) Update how-to-contribute.md to mention the style guide when writing blogs/tutorials (gatsbyjs#9742) Added Tylermcginnis website (gatsbyjs#9619) Fix grammar and punctuation (gatsbyjs#9498) Fix typo of plugin authoring (gatsbyjs#9737) Authentication tutorial - small fixes (gatsbyjs#9738) chore: move run-sift (gatsbyjs#9549) docs: fix minor typo (gatsbyjs#9730) chore(release): Publish fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored (gatsbyjs#9720) fix: revert admin redirect (gatsbyjs#9728) fix: adjust page order to make nested matchPaths work (gatsbyjs#9719) feat(gatsby-plugin-sharp): cache base64 if possible (gatsbyjs#9059) chore(release): Publish fix(gatsby-plugin-offline): Serve the offline shell for short URLs + use no-cors for external resources (gatsbyjs#9679) chore(release): Publish fix: ensure babel-preset-gatsby can be used with unit tests (gatsbyjs#9629) feat(www): Filter posts by date (gatsbyjs#9400) fix(blog): azure blog post url date (gatsbyjs#9718) feat(blog): Add post on publishing to Azure (gatsbyjs#8868) Emphasize importance of promise return on source-plugin docs (gatsbyjs#9650) ...
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
…ctually ignored (gatsbyjs#9720) * fix: ensure that __tests__ directory is actually ignored This (simple) PR fixes a bug I was noticing in gatsbyjs#9629, specifically that __tests__/*.js files _were_ being included in the bundle. This is because the isTestFile function in gatsby-plugin-page-creator is passed the file name, not the file name _with_ the folder (__tests__ in this case). I added a second check to check the dir, but could also just implement this check with the raw file path, as well * chore: use back ticks * fix: account for nested directories and switch to micromatch * chore: split to test windows path matching * chore: run linter * chore: add windows path matching test (micromatch supports natively) * fix: pass single string to isMatch, instead of array * Revert "fix: pass single string to isMatch, instead of array" This reverts commit dbc2ffe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (simple) PR fixes a bug I was noticing in #9629, specifically that
tests/*.js files were being included in the bundle.
This is because the isTestFile function in gatsby-plugin-page-creator is
passed the file name, not the file name with the folder (tests in
this case).
So, this PR does the following:
Note: I could've solved this by also passing the raw path (not system path parsed) but wanted to avoid any Windows idiosyncrasies just in case