chore: move run-sift #9549
chore: move run-sift #9549
Conversation
|
@pieh I just merged master. I really wish github would notify me when a PR I've submitted needs a merge. |
|
@Moocar I meant in here https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/redux/nodes.js#L30-L31 as this will benefit other usages of |
|
@pieh I'm hesitant to add caching inside the getNodesByType implementation. What if the function is called halfway through sourceNodes when new nodes are still being added? I think it still makes sense adding it during run-sift until loki is implemented. Since the redux version is quite slow. |
That's good point! We could do cache invalidation when we create/update/delete node of given type, but this is out of the scope for this PR. |
|
Was just testing locally, and this actually improve performance a little bit as the caching that You re-added in |
* 'master' of github.com:gatsbyjs/gatsby: (63 commits) Update how-to-contribute.md to mention the style guide when writing blogs/tutorials (gatsbyjs#9742) Added Tylermcginnis website (gatsbyjs#9619) Fix grammar and punctuation (gatsbyjs#9498) Fix typo of plugin authoring (gatsbyjs#9737) Authentication tutorial - small fixes (gatsbyjs#9738) chore: move run-sift (gatsbyjs#9549) docs: fix minor typo (gatsbyjs#9730) chore(release): Publish fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored (gatsbyjs#9720) fix: revert admin redirect (gatsbyjs#9728) fix: adjust page order to make nested matchPaths work (gatsbyjs#9719) feat(gatsby-plugin-sharp): cache base64 if possible (gatsbyjs#9059) chore(release): Publish fix(gatsby-plugin-offline): Serve the offline shell for short URLs + use no-cors for external resources (gatsbyjs#9679) chore(release): Publish fix: ensure babel-preset-gatsby can be used with unit tests (gatsbyjs#9629) feat(www): Filter posts by date (gatsbyjs#9400) fix(blog): azure blog post url date (gatsbyjs#9718) feat(blog): Add post on publishing to Azure (gatsbyjs#8868) Emphasize importance of promise return on source-plugin docs (gatsbyjs#9650) ...
* Add nodes namespace to support loki feature flag * naughty console log * switch for db nodes backend * move connection out of run-sift * revert snapshot for gatsby-remark-embed * typo * move node tracking into DB * move run-sift into redux * use runQuery instead of runSift * add caching of getNodesByType in run-sift * fix docs
* Add nodes namespace to support loki feature flag * naughty console log * switch for db nodes backend * move connection out of run-sift * revert snapshot for gatsby-remark-embed * typo * move node tracking into DB * move run-sift into redux * use runQuery instead of runSift * add caching of getNodesByType in run-sift * fix docs
Builds on #9508. Merge that first
Another refactoring PR before loki hits.
run-sifthas existed in schema up until now. This PR moves it to under thereduxfolder. The idea is thatschemadeals with the creation of a schema, but the resolver is code that performs a query against a database. This will make even more sense with loki.I've also moved
node-trackingfrom schema to db in anticipation that this will eventually be stored in the DB as well.