Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored #9720

Merged
merged 8 commits into from
Nov 6, 2018
Merged

fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored #9720

merged 8 commits into from
Nov 6, 2018

Commits on Nov 5, 2018

  1. fix: ensure that __tests__ directory is actually ignored 

    This (simple) PR fixes a bug I was noticing in gatsbyjs#9629, specifically that
__tests__/*.js files _were_ being included in the bundle.

This is because the isTestFile function in gatsby-plugin-page-creator is
passed the file name, not the file name _with_ the folder (__tests__ in
this case).

I added a second check to check the dir, but could also just implement
this check with the raw file path, as well
    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9dbf483 View commit details
    Browse the repository at this point in the history

  2. chore: use back ticks

    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    e996f73 View commit details
    Browse the repository at this point in the history

  3. fix: account for nested directories and switch to micromatch

    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    cad526e View commit details
    Browse the repository at this point in the history

  4. chore: split to test windows path matching

    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    7fbbfd5 View commit details
    Browse the repository at this point in the history

  5. chore: run linter

    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    59c5df2 View commit details
    Browse the repository at this point in the history

  6. chore: add windows path matching test (micromatch supports natively)

    @DSchau
    DSchau committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    182f02b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. fix: pass single string to isMatch, instead of array

    @DSchau
    DSchau committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    dbc2ffe View commit details
    Browse the repository at this point in the history

  2. Revert "fix: pass single string to isMatch, instead of array" 

    This reverts commit dbc2ffe.
    @DSchau
    DSchau committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    b377761 View commit details
    Browse the repository at this point in the history