Limit upstream-host label value to 43 chars #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/quality
gardener-prow
bot
added
the
size/M
dimitar-kostadinov
force-pushed
the
enh/upstream-host-label
branch
from
71b5099 to
2f3028a
Compare
96 tasks
gardener-prow
bot
added
the
needs-rebase
dimitar-kostadinov
force-pushed
the
enh/upstream-host-label
branch
from
2f3028a to
9baddf4
Compare
gardener-prow
bot
removed
the
needs-rebase
ialidzhikov
reviewed
May 8, 2024
|
LGTM label has been added. Git tree hash: 5213db4f1ee16b4d5b50b9b34a5a9bc12d479937
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
JordanJordanov
added
area/ipcei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
What this PR does / why we need it:
The value of labels in Kubernetes is limited to 63 chars. The value of the
upstream-hostlabel is used to construct the registry cache resource names (registry-<escaped-upstream-host-value>) and for the StatefulSet name the limit is 52 (see #129) . To use a uniform value for both labels and component names, theupstream-hostlabel value is limited to 43 chars.Currently the remote registry host (
caches[].upstream) is used forupstream-hostlabel value. If this value is longer than 43 chars it is transformed to<truncated-upstream>-<hash>where<truncated-upstream>is the upstream truncated to 37 char and<hash>is the first 5 chars ofupstreamSHA256.Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
Release note: