Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StatefulSet Pod creation for caches with a long upstream #129

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area quality
/kind bug

What this PR does / why we need it:
The reason for #120 is kubernetes/kubernetes#64023. Long story short the explanation is:

	// The StatefulSet name limit is 63 chars. However Pods for a StatefulSet with name > 52 chars cannot be created due to https://github.com/kubernetes/kubernetes/issues/64023.
	// The "controller-revision-hash" label gets added to the StatefulSet Pod. The label value is in format <stateful_set_name>_<hash> where <hash> is 10 or 11 chars.

With this PR we mitigate the upstream issue by NOT exceeding 52 chars for StatefulSet names. This change should be backwards-compatible.

Which issue(s) this PR fixes:
Fixes #120

Special notes for your reviewer:
For completeness, these are some size limits in K8s:

Release note:

An issue causing the registry StatefulSet to fail to create Pods for registry caches with long upstreams is now mitigated.

Copy link
Contributor

gardener-prow bot commented Jan 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug labels Jan 17, 2024
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Jan 17, 2024
@gardener-prow gardener-prow bot requested a review from Kostov6 January 17, 2024 15:41
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review January 18, 2024 07:37
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@dimitar-kostadinov dimitar-kostadinov self-assigned this Jan 18, 2024
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Minor nits inline

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link
Contributor

gardener-prow bot commented Jan 19, 2024

LGTM label has been added.

Git tree hash: b3ebb90425b6276216bbe903299d5a97b48da785

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2024
@ialidzhikov ialidzhikov force-pushed the fix/statefulset-naming branch from d51d02c to ca31619 Compare January 19, 2024 09:44
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2024
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link
Contributor

gardener-prow bot commented Jan 19, 2024

LGTM label has been added.

Git tree hash: 3407fdd6267e9d1f11708714325cf3887008e9f2

@ialidzhikov
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@gardener-prow gardener-prow bot merged commit b86dadc into gardener:main Jan 19, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the fix/statefulset-naming branch January 22, 2024 12:43
@JordanJordanov JordanJordanov added area/ipcei IPCEI (Important Project of Common European Interest) ipcei/registry-cache-extension Registry Cache Extension labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/registry-cache-extension Registry Cache Extension kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the statefulset naming convention shorter to accommodate longer registry name
3 participants