-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StatefulSet Pod creation for caches with a long upstream #129
Fix StatefulSet Pod creation for caches with a long upstream #129
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Minor nits inline
LGTM label has been added. Git tree hash: b3ebb90425b6276216bbe903299d5a97b48da785
|
d51d02c
to
ca31619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3407fdd6267e9d1f11708714325cf3887008e9f2
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area quality
/kind bug
What this PR does / why we need it:
The reason for #120 is kubernetes/kubernetes#64023. Long story short the explanation is:
With this PR we mitigate the upstream issue by NOT exceeding 52 chars for StatefulSet names. This change should be backwards-compatible.
Which issue(s) this PR fixes:
Fixes #120
Special notes for your reviewer:
For completeness, these are some size limits in K8s:
Release note: