-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the validation for a cache upstream #130
Improve the validation for a cache upstream #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d50da5e03fd63dc58ef7051c80d4660ca4b729ab
|
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
While working on #129 I noticed that we actually don't support upstreams with ports but our docs state that it is supported.
A Shoot reconciliation with a cache with upstream with a port (for example
public.ecr.aws:443
) fails with:The above message is for Secret but the same label with the same value gets added to all resources, incl. the StatefulSet. Hence, upstream with port was not working since the initial implementation.
This PR improves the validation for the cache upstream (requires to be a valid DNS subdomain (RFC 1123)) and properly updates docs so that it is clear that upstream with port is not supported.
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note: