Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the DeleteOnInvalidUpdate annotation #211

Conversation

dimitar-kostadinov
Copy link
Contributor

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:
Removes the DeleteOnInvalidUpdate annotation as registry cache StatefulSets for registries with upstream host with more than 43 chars are already recreated.
Ref: #186

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 19, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov June 19, 2024 14:17
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2024
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
Copy link
Contributor

gardener-prow bot commented Jun 19, 2024

LGTM label has been added.

Git tree hash: 7c4a5722e6e8db04706a5f1cc326c60beefb8711

Copy link
Contributor

gardener-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@gardener-prow gardener-prow bot merged commit ac72636 into gardener:main Jun 19, 2024
6 checks passed
@dimitar-kostadinov dimitar-kostadinov deleted the cleanup/delete-on-invalid-update branch February 26, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants