Resolve some reported minor issues #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses several points in gap-system#3764 Remove obsolete BasisRadical method Dualizing the socle is better since maximals aleady are computed through dualization. Documentation now states `InducedAction` only for nontrivial result. Make result of BasisSocle immutable.
hulpke
added
kind: quirk
fingolfin
reviewed
Jan 30, 2020
| @@ -2466,6 +2466,7 @@ InstallGlobalFunction(AssociatedPartition,function(lambda) | |||
| local res, k, j; | |||
| res := []; | |||
| k := Length(lambda); | |||
| if k=0 then return res;fi; # empty partition | |||
There was a problem hiding this comment.
A minimal test which just executes AssociatedPartition([]); would be nice.
fingolfin
approved these changes
Jan 31, 2020
|
I think I leave the backport question to those who would have to do the work. There shouldn't be a problem with it, but it is an extra step. I'll wait with merging for a day or two so that whoever wants can add the backport tag. |
fingolfin
pushed a commit
that referenced
this pull request
Feb 3, 2020
* CLEANUP: Minor MeatAxe quirks This addresses several points in #3764 Remove obsolete BasisRadical method Dualizing the socle is better since maximals aleady are computed through dualization. Documentation now states `InducedAction` only for nontrivial result. Make result of BasisSocle immutable. * FIX: AssociatedPartition for empty partition This closes #3854 * Added test.
|
Backported to stable-4.11 in commit a66ec38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes AssociatedPartition for the empty partition #3854
and some of the MeatAxe issues in #3764