Skip to content

Commit

Permalink
CLEANUP: Minor MeatAxe quirks
Browse files Browse the repository at this point in the history
This addresses several points in #3764

Remove obsolete BasisRadical method Dualizing the socle is better since
maximals aleady are computed through dualization.

Documentation now states `InducedAction` only for nontrivial result.
Make result of BasisSocle immutable.
  • Loading branch information
hulpke committed Jan 29, 2020
1 parent 75f9cb2 commit c64077b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
3 changes: 2 additions & 1 deletion doc/ref/meataxe.xml
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ and <A>change</A> is the base change from <A>bas</A> to <A>sub</A>

<Description>
creates a new module corresponding to the action of <A>module</A> on
the non-trivial submodule
<A>sub</A>.
In the <C>NB</C> version the basis <A>sub</A> must be normed.
(That is it must be in echelon form with pivots normed to 1,
Expand All @@ -405,7 +406,7 @@ see&nbsp;<Ref Func="MTX.NormedBasisAndBaseChange"/>.)

<Description>
creates a new module corresponding to the action of <A>module</A> on the
factor of <A>sub</A>. If <A>compl</A> is given, it has to be a basis of a
factor of the proper submodule <A>sub</A>. If <A>compl</A> is given, it has to be a basis of a
(vector space-)complement of <A>sub</A>. The action then will correspond to
<A>compl</A>.
<P/>
Expand Down
13 changes: 1 addition & 12 deletions lib/meataxe.gi
Original file line number Diff line number Diff line change
Expand Up @@ -3128,17 +3128,6 @@ local a,u,i,nb;
end;
SMTX.BasesMinimalSupermodules:=SMTX_BasesMinimalSupermodules;

SMTX_BasisRadical:=function(module)
local m,i,r;
m:=SMTX.BasesMaximalSubmodules(module);
r:=m[1];
for i in [2..Length(m)] do
r:=SumIntersectionMat(r,m[i])[2];
od;
return r;
end;
SMTX.BasisRadical:=SMTX_BasisRadical;

#############################################################################
##
#F SMTX.SpanOfMinimalSubGModules(m1, m2) . .
Expand Down Expand Up @@ -3182,7 +3171,7 @@ local cf, mat, i;
cf:=SMTX.CollectedFactors(module);
mat:=Concatenation(List(cf,i->SMTX_SpanOfMinimalSubGModules(i[1],module)));
if Length(cf) = 1 then
return mat;
return ImmutableMatrix(module.field,mat);
fi;
TriangulizeMat(mat);
mat:=ImmutableMatrix(module.field,mat);
Expand Down

0 comments on commit c64077b

Please sign in to comment.