Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssociatedPartition in GAP4.10.1 #3854

Closed
rtange opened this issue Jan 16, 2020 · 2 comments
Closed

AssociatedPartition in GAP4.10.1 #3854

rtange opened this issue Jan 16, 2020 · 2 comments
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them

Comments

@rtange
Copy link

rtange commented Jan 16, 2020

Minor point:
AssociatedPartition([]); gives an error message, but it should just give [] (as in GAP3).
Please delete or close this issue if this has already been corrected in GAP4.10.2.

My GAP banner:
 ┌───────┐   GAP 4.10.1 of 23-Feb-2019
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: i686-pc-cygwin-default32-kv3
 Configuration:  gmp 6.1.2, readline
 Loading the library and packages ...

@wucas
Copy link
Contributor

wucas commented Jan 16, 2020

I can reproduce this with GAP 4.10.2:

 ┌───────┐   GAP 4.10.2 of 19-Jun-2019
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-apple-darwin18.6.0-default64-kv3
 Configuration:  gmp 6.1.2
 Loading the library and packages ...
 Packages:   AClib 1.3.1, Alnuth 3.1.1, AtlasRep 2.1.0, AutoDoc 2019.05.20, AutPGrp 1.10, Browse 1.8.8, Carat 2.2.3, CRISP 1.4.4, Cryst 4.1.19, CrystCat 1.1.9, CTblLib 1.2.2, FactInt 1.6.2, FGA 1.4.0, 
             Forms 1.2.5, GAPDoc 1.6.2, genss 1.6.5, IO 4.6.0, IRREDSOL 1.4, LAGUNA 3.9.3, orb 4.8.2, Polenta 1.3.8, Polycyclic 2.14, PrimGrp 3.3.2, RadiRoot 2.8, recog 1.3.2, ResClasses 4.7.2, 
             SmallGrp 1.3, Sophus 1.24, SpinSym 1.5.1, TomLib 1.2.8, TransGrp 2.0.4, utils 0.63
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap> AssociatedPartition([]);
Error, List Element: <list>[1] must have an assigned value in
  for j in [ 1 .. lambda[1] ] do
    if j <= lambda[k] then
        res[j] := k;
    else
        k := k - 1;
        while j > lambda[k] do
            k := k - 1;
        od;
        res[j] := k;
    fi;
od; at /Users/lucas/Projects/gap-4.10.2/lib/combinat.gi:2478 called from 
<function "AssociatedPartition">( <arguments> )
 called from read-eval loop at *stdin*:1
you can 'return;' after assigning a value

and also in the current master branch:

 ┌───────┐   GAP 4.12dev-267-gb877da9 of today
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-apple-darwin19.2.0-default64-kv8
 Configuration:  gmp 6.1.2, GASMAN
 Loading the library and packages ...
#I  DeclareGlobalFunction: too many arguments in /Users/lucas/Projects/gap-dev/gap/pkg/crisp-1.4.4/lib/util.gd:16
Syntax warning: Unbound global variable in /Users/lucas/Projects/gap-dev/gap/pkg/atlasrep/gap/utils.gi:44
        pos:= POSITION_FIRST_COMPONENT_SORTED( WidthUnicodeTable, ints[j] );
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 Packages:   AClib 1.3.1, Alnuth 3.1.0, AtlasRep 1.5.1, AutoDoc 2019.02.22, AutPGrp 1.10, Browse 1.8.8, Carat 2.2.3, CRISP 1.4.4, Cryst 4.1.18, CrystCat 1.1.8, CTblLib 1.2.2, FactInt 1.6.2, FGA 1.4.0, 
             GAPDoc 1.6.2, IO 4.5.4, IRREDSOL 1.4, LAGUNA 3.9.2, Polenta 1.3.8, Polycyclic 2.14, PrimGrp 3.3.2, RadiRoot 2.8, ResClasses 4.7.1, SmallGrp 1.3, Sophus 1.24, SpinSym 1.5, TomLib 1.2.7, 
             TransGrp 2.0.4, utils 0.61
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap> AssociatedPartition([]);
Error, List Element: <list>[1] must have an assigned value in
  for j in [ 1 .. lambda[1] ] do
    if j <= lambda[k] then
        res[j] := k;
    else
        k := k - 1;
        while j > lambda[k] do
            k := k - 1;
        od;
        res[j] := k;
    fi;
od; at /Users/lucas/Projects/gap-dev/gap/lib/combinat.gi:2479 called from 
<function "AssociatedPartition">( <arguments> )
 called from read-eval loop at *stdin*:1
type 'quit;' to quit to outer loop

@wucas wucas added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them labels Jan 16, 2020
@fingolfin fingolfin added the good first issue Issues that can be understood and addressed by newcomers to GAP development label Jan 17, 2020
@fingolfin
Copy link
Member

The code in AssociatedPartition clearly does not take the empty set into account. It shouldn't be hard to write a patch to fix this, plus a test case. I've labelled this issue as "good first issue" now, in case some volunteers want to help out with it.

hulpke added a commit to hulpke/gap that referenced this issue Jan 21, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 21, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 21, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 21, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 22, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 28, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 29, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 29, 2020
hulpke added a commit to hulpke/gap that referenced this issue Jan 29, 2020
@hulpke hulpke closed this as completed in a2326e4 Feb 3, 2020
fingolfin pushed a commit that referenced this issue Feb 3, 2020
* CLEANUP: Minor MeatAxe quirks

This addresses several points in #3764

Remove obsolete BasisRadical method Dualizing the socle is better since
maximals aleady are computed through dualization.

Documentation now states `InducedAction` only for nontrivial result.
Make result of BasisSocle immutable.

* FIX: AssociatedPartition for empty partition

This closes #3854

* Added test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

No branches or pull requests

3 participants